Issue 13483022: cc: Turn on presubmit cpplint warnings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13483022: cc: Turn on presubmit cpplint warnings (Closed)

Created:
7 years, 8 months ago by enne (OOO)

Modified:
7 years, 8 months ago

Reviewers:
jamesr

CC:
chromium-reviews, cc-bugs_chromium.org, danakj

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

cc: Turn on presubmit cpplint warnings cc is nearly spotless with cpplint warnings, so let's keep it that way. The CommonChecks lint warning turns off a ton of errors that I would prefer to keep on. I turned it to level 1, since that's the default when running cpplint.py. This doesn't appear to be on by default. R=jamesr@chromium.org BUG=227196 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193021

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -0 lines)			Patch
	M	cc/PRESUBMIT.py	View		2 chunks	+19 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/13483022/1

7 years, 8 months ago (2013-04-08 21:07:24 UTC) #3

Message was sent while issue was closed.

Change committed as 193021

Expand Messages | Collapse Messages