Issue 13482012: fix layout of requestAutocomplete suggestion dropdown menu on views

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13482012: fix layout of requestAutocomplete suggestion dropdown menu on views (Closed)

Created:
7 years, 8 months ago by Evan Stade

Modified:
7 years, 8 months ago

Reviewers:
sky

CC:
chromium-reviews, Raman Kakilate, tfarina, benquan, dhollowa+watch_chromium.org, ahutter, dbeam+watch-autofill_chromium.org, Dane Wallinga, dyu1, Albert Bodenhamer, estade+watch_chromium.org, Ilya Sherman

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

fix layout of requestAutocomplete suggestion dropdown menu on views BUG=226755 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193002

Patch Set 1 #

Patch Set 2 : helper function #

Patch Set 3 : FIXME into comment #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -5 lines)			Patch
M	chrome/browser/ui/views/autofill/autofill_dialog_views.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	ui/views/controls/menu/menu_item_view.h	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	ui/views/controls/menu/menu_item_view.cc	View	1	3 chunks	+11 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/13482012/1003

7 years, 8 months ago (2013-04-08 22:54:40 UTC) #3

commit-bot: I haz the power

Retried try job too often on linux_chromeos for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=100685

7 years, 8 months ago (2013-04-09 00:17:58 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/13482012/1003

7 years, 8 months ago (2013-04-09 00:41:17 UTC) #5

Message was sent while issue was closed.

Change committed as 193002

Expand Messages | Collapse Messages