drive: Fix lifetime model of FileBrowserEventRouter

drive: Fix lifetime model of FileBrowserEventRouter

Previously, FileBrowserEventRouter was a ref counted class, but the weak pointer was
also used, which doesn't make much sense. Fix the weird lifetime model by making this
a non refcounted class.

Besides, in certain cases, FileBrowserEventRouter could outlive DBusThreadManager and
PrefService, which caused crash at shutdown.

BUG=227477
TEST=none

[hashimoto, 2013-04-08 04:49:38]

https://codereview.chromium.org/13474015/diff/1/chrome/browser/chromeos/exten...
File chrome/browser/chromeos/extensions/file_browser_event_router.cc (right):

https://codereview.chromium.org/13474015/diff/1/chrome/browser/chromeos/exten...
chrome/browser/chromeos/extensions/file_browser_event_router.cc:240:
weak_factory_(this) {
nit: ALLOW_THIS_IN_INITIALIZER_LIST?

https://codereview.chromium.org/13474015/diff/1/chrome/browser/chromeos/exten...
File chrome/browser/chromeos/extensions/file_browser_event_router.h (right):

https://codereview.chromium.org/13474015/diff/1/chrome/browser/chromeos/exten...
chrome/browser/chromeos/extensions/file_browser_event_router.h:43: virtual
~FileBrowserEventRouter();
nit: How about moving this dtor to after SuspendStateDelegate?

https://codereview.chromium.org/13474015/diff/1/chrome/browser/chromeos/exten...
chrome/browser/chromeos/extensions/file_browser_event_router.h:149: explicit
FileBrowserEventRouter(Profile* profile);
Can't we make this ctor public and remove "friend class FileBrowserPrivateAPI"?
If we are to keep "friend class FileBrowserPrivateAPI", we don't have to make
the dtor public.

[satorux1, 2013-04-08 05:03:37]

https://codereview.chromium.org/13474015/diff/1/chrome/browser/chromeos/exten...
File chrome/browser/chromeos/extensions/file_browser_event_router.cc (right):

https://codereview.chromium.org/13474015/diff/1/chrome/browser/chromeos/exten...
chrome/browser/chromeos/extensions/file_browser_event_router.cc:240:
weak_factory_(this) {
On 2013/04/08 04:49:38, hashimoto wrote:
> nit: ALLOW_THIS_IN_INITIALIZER_LIST?

Done.

https://codereview.chromium.org/13474015/diff/1/chrome/browser/chromeos/exten...
File chrome/browser/chromeos/extensions/file_browser_event_router.h (right):

https://codereview.chromium.org/13474015/diff/1/chrome/browser/chromeos/exten...
chrome/browser/chromeos/extensions/file_browser_event_router.h:43: virtual
~FileBrowserEventRouter();
On 2013/04/08 04:49:38, hashimoto wrote:
> nit: How about moving this dtor to after SuspendStateDelegate?

Done.

https://codereview.chromium.org/13474015/diff/1/chrome/browser/chromeos/exten...
chrome/browser/chromeos/extensions/file_browser_event_router.h:149: explicit
FileBrowserEventRouter(Profile* profile);
On 2013/04/08 04:49:38, hashimoto wrote:
> Can't we make this ctor public and remove "friend class
FileBrowserPrivateAPI"?
> If we are to keep "friend class FileBrowserPrivateAPI", we don't have to make
> the dtor public.

Done. Good catch!

[hashimoto, 2013-04-08 05:04:50]

lgtm

[commit-bot: I haz the power, 2013-04-08 06:22:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/satorux@chromium.org/13474015/5001

[commit-bot: I haz the power, 2013-04-08 06:26:42]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_chromeos_clang.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[satorux1, 2013-04-08 06:34:36]

https://codereview.chromium.org/13474015/diff/5001/chrome/browser/chromeos/ex...
File chrome/browser/chromeos/extensions/file_browser_event_router.cc (right):

https://codereview.chromium.org/13474015/diff/5001/chrome/browser/chromeos/ex...
chrome/browser/chromeos/extensions/file_browser_event_router.cc:355:
weak_factory_.GetWeakPtr(), true));
Hmm, this is also broken, as  weak_factory_.GetWeakPtr() is called from FILE
thread!

https://codereview.chromium.org/13474015/diff/5001/chrome/browser/chromeos/ex...
File chrome/browser/chromeos/extensions/file_browser_private_api.cc (right):

https://codereview.chromium.org/13474015/diff/5001/chrome/browser/chromeos/ex...
chrome/browser/chromeos/extensions/file_browser_private_api.cc:723:
FileBrowserEventRouter* event_router,
I think this is unsafe, as |event_router| could be already deleted by the time
this function is called on FILE thread...

Let me see if I can fix this: crbug.com/227483.

[satorux1, 2013-04-08 08:28:58]

closing as this is not gonna work...