Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Unified Diff: remoting/base/util.cc

Issue 13474013: Use libyuv for non-scaling RGB<->YUV conversions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Increase Gradient test thresholds. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/DEPS ('k') | remoting/codec/video_decoder_vp8_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/base/util.cc
diff --git a/remoting/base/util.cc b/remoting/base/util.cc
index 53b121352954d103a343ea887626e2abce36d110..dc9104d00270f2a060d52ba90c59cf3273050ace 100644
--- a/remoting/base/util.cc
+++ b/remoting/base/util.cc
@@ -11,6 +11,7 @@
#include "base/time.h"
#include "media/base/video_frame.h"
#include "media/base/yuv_convert.h"
+#include "third_party/libyuv/include/libyuv/convert.h"
#include "third_party/skia/include/core/SkRegion.h"
#if defined(OS_POSIX)
@@ -65,15 +66,11 @@ void ConvertRGB32ToYUVWithRect(const uint8* rgb_plane,
int y_offset = CalculateYOffset(x, y, y_stride);
int uv_offset = CalculateUVOffset(x, y, uv_stride);;
- media::ConvertRGB32ToYUV(rgb_plane + rgb_offset,
- y_plane + y_offset,
- u_plane + uv_offset,
- v_plane + uv_offset,
- width,
- height,
- rgb_stride,
- y_stride,
- uv_stride);
+ libyuv::ARGBToI420(rgb_plane + rgb_offset, rgb_stride,
+ y_plane + y_offset, y_stride,
+ u_plane + uv_offset, uv_stride,
+ v_plane + uv_offset, uv_stride,
+ width, height);
}
void ConvertAndScaleYUVToRGB32Rect(const uint8* source_yplane,
@@ -111,7 +108,7 @@ void ConvertAndScaleYUVToRGB32Rect(const uint8* source_yplane,
// See if scaling is needed.
if (source_size == dest_size) {
// Calculate the inner rectangle that can be copied by the optimized
- // ConvertYUVToRGB32().
+ // libyuv::I420ToARGB().
SkIRect inner_rect =
SkIRect::MakeLTRB(RoundToTwosMultiple(dest_rect.left() + 1),
RoundToTwosMultiple(dest_rect.top() + 1),
@@ -126,16 +123,11 @@ void ConvertAndScaleYUVToRGB32Rect(const uint8* source_yplane,
rgb_offset += CalculateRGBOffset(inner_rect.x(), inner_rect.y(),
dest_stride);
- media::ConvertYUVToRGB32(source_yplane + y_offset,
- source_uplane + uv_offset,
- source_vplane + uv_offset,
- dest_buffer + rgb_offset,
- inner_rect.width(),
- inner_rect.height(),
- source_ystride,
- source_uvstride,
- dest_stride,
- media::YV12);
+ libyuv::I420ToARGB(source_yplane + y_offset, source_ystride,
+ source_uplane + uv_offset, source_uvstride,
+ source_vplane + uv_offset, source_uvstride,
+ dest_buffer + rgb_offset, dest_stride,
+ inner_rect.width(), inner_rect.height());
// Now see if some pixels weren't copied due to alignment.
if (dest_rect != inner_rect) {
« no previous file with comments | « remoting/DEPS ('k') | remoting/codec/video_decoder_vp8_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698