Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 13473009: Do not implicitly convert non-object receivers for strict mode functions. (Closed)

Created:
7 years, 8 months ago by Yang
Modified:
7 years, 8 months ago
Reviewers:
rossberg
CC:
v8-dev
Visibility:
Public.

Description

Do not implicitly convert non-object receivers for strict mode functions. This was still the case for Array.prototype.* builtin functions. R=rossberg@chromium.org BUG=v8:2273 Committed: https://code.google.com/p/v8/source/detail?r=14149

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -5 lines) Patch
M src/array.js View 5 chunks +6 lines, -5 lines 0 comments Download
M src/runtime.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime.cc View 1 chunk +18 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-2273.js View 1 chunk +103 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
7 years, 8 months ago (2013-04-02 17:45:09 UTC) #1
rossberg
lgtm
7 years, 8 months ago (2013-04-03 16:48:01 UTC) #2
Yang
7 years, 8 months ago (2013-04-05 11:57:12 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r14149 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698