Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1143)

Unified Diff: build/win/importlibs/create_importlib_win.py

Issue 13472015: Quench build spew. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/win/importlibs/create_import_lib.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/win/importlibs/create_importlib_win.py
diff --git a/build/win/importlibs/create_importlib_win.py b/build/win/importlibs/create_importlib_win.py
index e71bfe4c225c7929cd282ef53ff1384ed1ab54e1..bb6a2f02636d8e40674fa3eca3eab82299758c5f 100755
--- a/build/win/importlibs/create_importlib_win.py
+++ b/build/win/importlibs/create_importlib_win.py
@@ -115,7 +115,7 @@ class _ImportLibraryGenerator(object):
# Invoke on the assembler to compile it to .obj.
obj_name = dll_name + '.obj'
cmdline = ['ml.exe', '/nologo', '/c', asm_name, '/Fo', obj_name]
- self._Shell(cmdline, cwd=self._temp_dir)
+ self._Shell(cmdline, cwd=self._temp_dir, stdout=open(os.devnull))
return obj_name
@@ -151,7 +151,7 @@ class _ImportLibraryGenerator(object):
if obj_file:
cmdline.append(obj_file)
- self._Shell(cmdline, cwd=self._temp_dir)
+ self._Shell(cmdline, cwd=self._temp_dir, stdout=open(os.devnull))
# Copy the .lib file to the output directory.
shutil.copyfile(os.path.join(self._temp_dir, lib_name), output_file)
@@ -181,7 +181,6 @@ def main():
options, args = parser.parse_args()
- print args
if len(args) != 1:
parser.error('You must provide an imports file.')
@@ -204,7 +203,7 @@ def main():
ret = generator.CreateImportLib(args[0], options.output_file)
except Exception, e:
- _LOGGER.exception('Failed to create imports.')
+ _LOGGER.exception('Failed to create import lib.')
ret = 1
finally:
if not options.keep_temp_dir:
« no previous file with comments | « build/win/importlibs/create_import_lib.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698