Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 13470027: Revert "Make gclient fetch git repos recursively. This is needed when adding a git repo through DEP… (Closed)

Created:
7 years, 8 months ago by iannucci
Modified:
7 years, 8 months ago
Reviewers:
cmp, cmp_google
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, jam, szager1
Visibility:
Public.

Description

Revert "Make gclient fetch git repos recursively. This is needed when adding a git repo through DEPS. If that repo has submodules, we need to fetch them or else the repo won't be complete." This reverts commit 6a2e4710bf3bbde9ab3f8c5ce44f7e9cd1fb3036. cmp says: This CL causes NewGit and Git submodules workflows to comingle in ways that result in bad and unexpected failures for new and existing users. One failure is for the new Blink developers who need to use git-svn with their WebKit third_party checkout. Another failure is in the Windows NewGit workflow where gclient sync takes longer than necessary to complete. The right approach at this point given the costs of this change is to revert it and rethink the best way to get projects the functionality they need while restoring the functionality existing projects have required for over a year now. Please discuss the recursive/recurseSubmodules code face-to-face with cmp@google.com before attempting to make this live again. Thanks. R=cmp@chromium.org BUG=224074 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=192236

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M gclient_scm.py View 3 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
iannucci
7 years, 8 months ago (2013-04-04 07:49:34 UTC) #1
cmp_google
lgtm
7 years, 8 months ago (2013-04-04 07:51:00 UTC) #2
cmp_google
+szager fyi
7 years, 8 months ago (2013-04-04 07:52:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iannucci@chromium.org/13470027/1
7 years, 8 months ago (2013-04-04 07:55:13 UTC) #4
commit-bot: I haz the power
7 years, 8 months ago (2013-04-04 07:57:18 UTC) #5
Message was sent while issue was closed.
Change committed as 192236

Powered by Google App Engine
This is Rietveld 408576698