Issue 13470026: Suppress Ant build noise

Issue 13470026: Suppress Ant build noise (Closed)

Created:
7 years, 8 months ago by cjhopman

Modified:
7 years, 8 months ago

Reviewers:
newt (away)

CC:
chromium-reviews, klundberg+watch_chromium.org, frankf+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Suppress Ant build noise Use a simple wrapper script for calling ant. This allows us to suppress the "BUILD SUCCESSFUL" + timing output from ant. BUG=164395 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192478

Patch Set 1 : #

Patch Set 2 : Remove stray import #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -5 lines)			Patch
A	build/android/gyp/ant.py	View	1 2	1 chunk	+30 lines, -0 lines	0 comments	Download
M	build/apk_test.gypi	View		1 chunk	+4 lines, -1 line	0 comments	Download
M	build/java_apk.gypi	View	1 2 3	8 chunks	+13 lines, -4 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

newt (away)

lgtm with one nit https://codereview.chromium.org/13470026/diff/5002/build/android/gyp/ant.py File build/android/gyp/ant.py (right): https://codereview.chromium.org/13470026/diff/5002/build/android/gyp/ant.py#newcode23 build/android/gyp/ant.py:23: if 'BUILD SUCCESSFUL' in line: ...

7 years, 8 months ago (2013-04-04 01:41:43 UTC) #2

cjhopman

https://codereview.chromium.org/13470026/diff/5002/build/android/gyp/ant.py File build/android/gyp/ant.py (right): https://codereview.chromium.org/13470026/diff/5002/build/android/gyp/ant.py#newcode23 build/android/gyp/ant.py:23: if 'BUILD SUCCESSFUL' in line: On 2013/04/04 01:41:43, newt ...

7 years, 8 months ago (2013-04-04 16:38:30 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/13470026/23001

7 years, 8 months ago (2013-04-04 16:38:40 UTC) #4

commit-bot: I haz the power

Step "update" is always a major failure. Look at the try server FAQ for more ...

7 years, 8 months ago (2013-04-04 16:46:08 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/13470026/36001

7 years, 8 months ago (2013-04-05 00:12:10 UTC) #6

Message was sent while issue was closed.

Change committed as 192478

Expand Messages | Collapse Messages