Issue 13469003: Android: nits following library loader changes.

Issue 13469003: Android: nits following library loader changes. (Closed)

Created:
7 years, 8 months ago by bulach

Modified:
7 years, 8 months ago

Reviewers:
cjhopman, joth, benm (inactive)

CC:
chromium-reviews, jam, ilevy+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, yfriedman+watch_chromium.org, bulach+watch_chromium.org, klundberg+watch_chromium.org, android-webview-reviews_chromium.org, frankf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Android: nits following library loader changes. Truly small follow-up from r191695. No functional changes. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=191930

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -9 lines)			Patch
M	android_webview/java/generated_src/org/chromium/content/app/NativeLibraries.java	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	build/android/create_native_libraries_header.py	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	build/android/gcc_preprocess.py	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	build/android/write_ordered_libraries.py	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	content/public/android/java/src/org/chromium/content/app/LibraryLoader.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/public/android/java/templates/NativeLibraries.template	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/13469003/1

7 years, 8 months ago (2013-04-02 16:47:07 UTC) #3

commit-bot: I haz the power

Presubmit check for 13469003-1 failed and returned exit status 1. INFO:root:Found 6 file(s). INFO:PRESUBMIT:Skipping pylint: ...

7 years, 8 months ago (2013-04-02 16:47:12 UTC) #4

joth

lgtm On 2 April 2013 09:52, <bulach@chromium.org> wrote: > +benm for trivial changes in android_webview ...

7 years, 8 months ago (2013-04-02 17:14:22 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/13469003/1

7 years, 8 months ago (2013-04-02 18:48:15 UTC) #7

Message was sent while issue was closed.

Change committed as 191930

Expand Messages | Collapse Messages