Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 13465019: Fix for effect cache key (Closed)

Created:
7 years, 8 months ago by jvanverth1
Modified:
7 years, 8 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Fix for effect cache key. Adds the additional shift needed to incorporate the attribKeyBits. Also simplifies the creation of the static globals for the edge effects. Committed: http://code.google.com/p/skia/source/detail?r=8498

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -16 lines) Patch
M include/gpu/GrTBackendEffectFactory.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrAAConvexPathRenderer.cpp View 2 chunks +4 lines, -5 lines 0 comments Download
M src/gpu/GrAAHairLinePathRenderer.cpp View 2 chunks +8 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jvanverth1
7 years, 8 months ago (2013-04-02 20:46:00 UTC) #1
bsalomon
lgtm
7 years, 8 months ago (2013-04-02 20:47:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jvanverth@google.com/13465019/1
7 years, 8 months ago (2013-04-02 20:48:33 UTC) #3
commit-bot: I haz the power
7 years, 8 months ago (2013-04-02 20:48:43 UTC) #4
Message was sent while issue was closed.
Change committed as 8498

Powered by Google App Engine
This is Rietveld 408576698