Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Issue 13464016: Renable tabCapture.ApiTests* now that fix landed in r191910. (Closed)

Created:
7 years, 8 months ago by justinlin
Modified:
7 years, 8 months ago
Reviewers:
Matt Perry
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org, phoglund_chromium
Visibility:
Public.

Description

Renable tabCapture.ApiTests* now that fix landed in r191910. Delete duplicated tests (they were moved to ApiTestsAudio). BUG=224249 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192021 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192973

Patch Set 1 #

Patch Set 2 : disable for WinXP #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -35 lines) Patch
M chrome/browser/extensions/api/tab_capture/tab_capture_apitest.cc View 1 2 chunks +19 lines, -4 lines 0 comments Download
M chrome/test/data/extensions/api_test/tab_capture/experimental/api_tests.js View 1 chunk +0 lines, -31 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
justinlin
7 years, 8 months ago (2013-04-02 22:26:10 UTC) #1
Matt Perry
lgtm
7 years, 8 months ago (2013-04-02 22:27:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/justinlin@chromium.org/13464016/1
7 years, 8 months ago (2013-04-02 22:29:02 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=130285
7 years, 8 months ago (2013-04-02 23:45:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/justinlin@chromium.org/13464016/1
7 years, 8 months ago (2013-04-02 23:46:27 UTC) #5
commit-bot: I haz the power
Change committed as 192021
7 years, 8 months ago (2013-04-03 08:20:44 UTC) #6
phoglund_chromium
On 2013/04/03 08:20:44, I haz the power (commit-bot) wrote: > Change committed as 192021 The ...
7 years, 8 months ago (2013-04-03 09:15:55 UTC) #7
justinlin
I looked at the bots when this was disabled, and looked like everything was all ...
7 years, 8 months ago (2013-04-08 20:12:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/justinlin@chromium.org/13464016/20001
7 years, 8 months ago (2013-04-08 20:31:16 UTC) #9
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-08 20:55:57 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/justinlin@chromium.org/13464016/26004
7 years, 8 months ago (2013-04-08 21:13:10 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/justinlin@chromium.org/13464016/26004
7 years, 8 months ago (2013-04-08 21:55:26 UTC) #12
commit-bot: I haz the power
7 years, 8 months ago (2013-04-09 00:43:43 UTC) #13
Message was sent while issue was closed.
Change committed as 192973

Powered by Google App Engine
This is Rietveld 408576698