Omnibox: Speed Up SearchProviderTest

Omnibox: Speed Up SearchProviderTest

By reducing the time waited between sending a Autocomplete request and
SearchProvider sending the request to mocked suggest server.

The speeds up the wall time of running SearchProvider test from 30 seconds to 20 seconds.

BUG=


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192584

[Mark P, 2013-04-03 16:10:04]

Fairly straightforward.

--mark

[Peter Kasting, 2013-04-03 21:38:43]

LGTM

[msw, 2013-04-03 21:46:07]

https://codereview.chromium.org/13461012/diff/12001/chrome/browser/autocomple...
File chrome/browser/autocomplete/search_provider.cc (right):

https://codereview.chromium.org/13461012/diff/12001/chrome/browser/autocomple...
chrome/browser/autocomplete/search_provider.cc:125: // To avoid flooding the
suggest server, don't send a query until at least 100
nit: keep this comment with its use in StartOrStopSuggestQuery or move it to the
declaration in the header.

https://codereview.chromium.org/13461012/diff/12001/chrome/browser/autocomple...
File chrome/browser/autocomplete/search_provider.h (right):

https://codereview.chromium.org/13461012/diff/12001/chrome/browser/autocomple...
chrome/browser/autocomplete/search_provider.h:471: static int
kMinimumTimeBetweenSuggestQueriesMs;
static class members should be listed after structs/enums and before
ctors/dtors, according to the style guide.

[Mark P, 2013-04-03 22:51:40]

https://codereview.chromium.org/13461012/diff/12001/chrome/browser/autocomple...
File chrome/browser/autocomplete/search_provider.cc (right):

https://codereview.chromium.org/13461012/diff/12001/chrome/browser/autocomple...
chrome/browser/autocomplete/search_provider.cc:125: // To avoid flooding the
suggest server, don't send a query until at least 100
On 2013/04/03 21:46:08, msw wrote:
> nit: keep this comment with its use in StartOrStopSuggestQuery or move it to
the
> declaration in the header.

Done.  Moved back to old location.

https://codereview.chromium.org/13461012/diff/12001/chrome/browser/autocomple...
File chrome/browser/autocomplete/search_provider.h (right):

https://codereview.chromium.org/13461012/diff/12001/chrome/browser/autocomple...
chrome/browser/autocomplete/search_provider.h:471: static int
kMinimumTimeBetweenSuggestQueriesMs;
On 2013/04/03 21:46:08, msw wrote:
> static class members should be listed after structs/enums and before
> ctors/dtors, according to the style guide.

Moved higher.  Is the new location where you want it?

[msw, 2013-04-03 23:28:48]

Sorry, I'm not trying to be obtuse, just correct :p

https://codereview.chromium.org/13461012/diff/16001/chrome/browser/autocomple...
File chrome/browser/autocomplete/search_provider.cc (right):

https://codereview.chromium.org/13461012/diff/16001/chrome/browser/autocomple...
chrome/browser/autocomplete/search_provider.cc:125: int
SearchProvider::kMinimumTimeBetweenSuggestQueriesMs = 100;
optional nit: technically definition order should match declaration order, so I
guess this would belong at line 500, just before
SearchProvider::~SearchProvider()... but this does seem like a better spot.

https://codereview.chromium.org/13461012/diff/16001/chrome/browser/autocomple...
File chrome/browser/autocomplete/search_provider.h (right):

https://codereview.chromium.org/13461012/diff/16001/chrome/browser/autocomple...
chrome/browser/autocomplete/search_provider.h:31: class SearchProviderTest;
nit: alphabetize this.

https://codereview.chromium.org/13461012/diff/16001/chrome/browser/autocomple...
chrome/browser/autocomplete/search_provider.h:89: static const int
kDefaultProviderURLFetcherID;
optional nit: move this and kKeywordProviderURLFetcherID to line 56 before the
SearchProvider ctor to conform to the C++ style guide.

https://codereview.chromium.org/13461012/diff/16001/chrome/browser/autocomple...
chrome/browser/autocomplete/search_provider.h:253: static int
kMinimumTimeBetweenSuggestQueriesMs;
This belongs at line 102 before "virtual ~SearchProvider();" if you wish for it
to be private and conform to the C++ style guide.

[Mark P, 2013-04-03 23:58:39]

https://codereview.chromium.org/13461012/diff/16001/chrome/browser/autocomple...
File chrome/browser/autocomplete/search_provider.cc (right):

https://codereview.chromium.org/13461012/diff/16001/chrome/browser/autocomple...
chrome/browser/autocomplete/search_provider.cc:125: int
SearchProvider::kMinimumTimeBetweenSuggestQueriesMs = 100;
On 2013/04/03 23:28:48, msw wrote:
> optional nit: technically definition order should match declaration order, so
I
> guess this would belong at line 500, just before
> SearchProvider::~SearchProvider()... but this does seem like a better spot.

Acknowledged.  Left as is.

https://codereview.chromium.org/13461012/diff/16001/chrome/browser/autocomple...
File chrome/browser/autocomplete/search_provider.h (right):

https://codereview.chromium.org/13461012/diff/16001/chrome/browser/autocomple...
chrome/browser/autocomplete/search_provider.h:31: class SearchProviderTest;
On 2013/04/03 23:28:48, msw wrote:
> nit: alphabetize this.

Done.

https://codereview.chromium.org/13461012/diff/16001/chrome/browser/autocomple...
chrome/browser/autocomplete/search_provider.h:89: static const int
kDefaultProviderURLFetcherID;
On 2013/04/03 23:28:48, msw wrote:
> optional nit: move this and kKeywordProviderURLFetcherID to line 56 before the
> SearchProvider ctor to conform to the C++ style guide.

Done.

https://codereview.chromium.org/13461012/diff/16001/chrome/browser/autocomple...
chrome/browser/autocomplete/search_provider.h:253: static int
kMinimumTimeBetweenSuggestQueriesMs;
On 2013/04/03 23:28:48, msw wrote:
> This belongs at line 102 before "virtual ~SearchProvider();" if you wish for
it
> to be private and conform to the C++ style guide.

Done.

[msw, 2013-04-04 00:05:14]

LGTM, thanks!

[commit-bot: I haz the power, 2013-04-05 14:41:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mpearson@chromium.org/13461012/25001

[commit-bot: I haz the power, 2013-04-05 16:59:28]

Change committed as 192584