Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(674)

Issue 13460015: Base Security: fix-up overflow tests (Closed)

Created:
7 years, 8 months ago by jln (very slow on Chromium)
Modified:
7 years, 8 months ago
Reviewers:
jschuh
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

Base Security: fix-up overflow tests - Re-enable NewOverflow on Windows for the most part - Strengthen the compiler barrier on GCC compatible compilers BUG=174947 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192031

Patch Set 1 : #

Patch Set 2 : Remove old invalid comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -9 lines) Patch
M base/security_unittest.cc View 1 4 chunks +13 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jln (very slow on Chromium)
Justin, do you mind taking a quick look ? (try bots runs are in patchset ...
7 years, 8 months ago (2013-04-03 00:33:45 UTC) #1
jschuh
On 2013/04/03 00:33:45, Julien Tinnes wrote: > Justin, do you mind taking a quick look ...
7 years, 8 months ago (2013-04-03 03:05:00 UTC) #2
jln (very slow on Chromium)
On 2013/04/03 03:05:00, Justin Schuh wrote: > On 2013/04/03 00:33:45, Julien Tinnes wrote: > > ...
7 years, 8 months ago (2013-04-03 06:52:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jln@chromium.org/13460015/4002
7 years, 8 months ago (2013-04-03 06:53:20 UTC) #4
commit-bot: I haz the power
7 years, 8 months ago (2013-04-03 09:02:27 UTC) #5
Message was sent while issue was closed.
Change committed as 192031

Powered by Google App Engine
This is Rietveld 408576698