Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 13455004: Forward-declare enums in a way that is compatible with NS_ENUM (Closed)

Created:
7 years, 8 months ago by stuartmorgan
Modified:
7 years, 8 months ago
Reviewers:
Nico
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Forward-declare enums in a way that is compatible with NS_ENUM Starting with the 10.8 SDK and the iOS 6.0 SDK, enums are declared strongly typed in C++11 mode, which the old forward-declares weren't compatible with. This creates a new macro for forward-declaring these enums in a way that will match the SDK and compilation mode. BUG=226494 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192543

Patch Set 1 #

Patch Set 2 : Don't check objc_fixed_enum #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M base/mac/foundation_util.h View 1 1 chunk +12 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
stuartmorgan
I simplified slightly from the SDK's ifdef; it also checks toolchain version and has handling ...
7 years, 8 months ago (2013-04-04 17:05:01 UTC) #1
Nico
lgtm (Do you want to have some tracking bug for turning on c++11 for chrome/ios?)
7 years, 8 months ago (2013-04-04 17:07:58 UTC) #2
stuartmorgan
On 2013/04/04 17:07:58, Nico wrote: > (Do you want to have some tracking bug for ...
7 years, 8 months ago (2013-04-04 17:18:49 UTC) #3
Nico
still lgtm
7 years, 8 months ago (2013-04-04 17:20:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stuartmorgan@chromium.org/13455004/3001
7 years, 8 months ago (2013-04-05 07:01:21 UTC) #5
commit-bot: I haz the power
7 years, 8 months ago (2013-04-05 10:45:09 UTC) #6
Message was sent while issue was closed.
Change committed as 192543

Powered by Google App Engine
This is Rietveld 408576698