Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 13454020: [MIPS] Small updates after LLVM merge (Closed)

Created:
7 years, 8 months ago by petarj
Modified:
7 years, 8 months ago
Reviewers:
Mark Seaborn
CC:
native-client-reviews_googlegroups.com
Base URL:
http://git.chromium.org/native_client/src/native_client.git@master
Visibility:
Public.

Description

[MIPS] Small updates after LLVM merge The change includes several small fixes: 1. set registers $at and $gp to zero when switching to untrusted code to avoid leaks from trusted code; 2. ignore MIPS reginfo section (generated with recently merged trunk code) 3. info message for the MIPS toolchain should print "nacl_sdk" to reflect recent changes in the toolchain script. BUG= https://code.google.com/p/nativeclient/issues/detail?id=2275 TEST= run smoke tests Committed: http://src.chromium.org/viewvc/native_client?view=rev&revision=11151

Patch Set 1 #

Patch Set 2 : Fix license header. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -29 lines) Patch
M SConstruct View 1 chunk +1 line, -1 line 0 comments Download
M src/include/elf_constants.h View 1 2 chunks +6 lines, -28 lines 0 comments Download
M src/trusted/service_runtime/arch/mips/nacl_switch.S View 2 chunks +2 lines, -0 lines 0 comments Download
M src/trusted/service_runtime/elf_util.c View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
petarj
7 years, 8 months ago (2013-04-05 17:25:32 UTC) #1
Mark Seaborn
LGTM
7 years, 8 months ago (2013-04-08 21:51:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://nativeclient-status.appspot.com/cq/petarj@mips.com/13454020/1
7 years, 8 months ago (2013-04-08 21:56:21 UTC) #3
commit-bot: I haz the power
Presubmit check for 13454020-1 failed and returned exit status 1. INFO:root:Found 4 file(s). Running presubmit ...
7 years, 8 months ago (2013-04-08 21:56:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://nativeclient-status.appspot.com/cq/petarj@mips.com/13454020/22001
7 years, 8 months ago (2013-04-08 22:27:26 UTC) #5
commit-bot: I haz the power
7 years, 8 months ago (2013-04-09 15:30:41 UTC) #6
Message was sent while issue was closed.
Change committed as 11151

Powered by Google App Engine
This is Rietveld 408576698