Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 13454006: Moving ManagedNetworkConfigurationHandler to chromeos/. (Closed)

Created:
7 years, 8 months ago by pneubeck (no reviews)
Modified:
7 years, 8 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, nkostylev+watch_chromium.org, gspencer+watch_chromium.org, gauravsh+watch_chromium.org, Aaron Boodman, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Moving ManagedNetworkConfigurationHandler to chromeos/. Also moving the dependencies of the handler to chromeos/: NetworkUIData from chrome/browser/chromeos/cros/network_ui_data* to chromeos/network/network_ui_data* NetworkPropertyUIData from chrome/browser/chromeos/cros/network_ui_data* to chrome/browser/chromeos/cros/network_property_ui_data* CreateNetworkUIData from chrome/browser/chromeos/net/onc_utils* to chromeos/network/network_ui_data* CertificatePattern from chrome/browser/chromeos/cros/certificate_pattern* to chromeos/network/certificate_pattern* Certificate pattern matching (was a member function of CertificatePatern) from chrome/browser/chromeos/cros/certificate_pattern* to chrome/browser/chromeos/cros/certificate_pattern_matcher* The only implementation change is in network_ui_data.cc in order to break dependency on EnumMapper. NetworkUIData and CertificatePattern are data keeping classes only, and will eventually be replaced by ONC. However, we need them for backwards compatibility for a while. BUG=180711 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193364

Patch Set 1 : Initial patch. #

Patch Set 2 : Uploaded missing unittest file. #

Patch Set 3 : Moved CreateUIData from ONC. #

Total comments: 2

Patch Set 4 : Cleaned up parsing of NetworkUIData. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+309 lines, -2456 lines) Patch
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 2 chunks +1 line, -1 line 0 comments Download
D chrome/browser/chromeos/cros/certificate_pattern.h View 1 chunk +0 lines, -140 lines 0 comments Download
D chrome/browser/chromeos/cros/certificate_pattern.cc View 1 chunk +0 lines, -352 lines 0 comments Download
A chrome/browser/chromeos/cros/certificate_pattern_matcher.h View 1 chunk +25 lines, -0 lines 0 comments Download
A + chrome/browser/chromeos/cros/certificate_pattern_matcher.cc View 8 chunks +50 lines, -209 lines 0 comments Download
M chrome/browser/chromeos/cros/network_constants.h View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/cros/network_library.h View 1 chunk +2 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/cros/network_library.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/cros/network_library_impl_base.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
A + chrome/browser/chromeos/cros/network_property_ui_data.h View 2 chunks +9 lines, -71 lines 0 comments Download
A + chrome/browser/chromeos/cros/network_property_ui_data.cc View 1 2 1 chunk +3 lines, -92 lines 0 comments Download
A + chrome/browser/chromeos/cros/network_property_ui_data_unittest.cc View 1 2 chunks +4 lines, -67 lines 0 comments Download
D chrome/browser/chromeos/cros/network_ui_data.h View 1 chunk +0 lines, -136 lines 0 comments Download
D chrome/browser/chromeos/cros/network_ui_data.cc View 1 chunk +0 lines, -151 lines 0 comments Download
D chrome/browser/chromeos/cros/network_ui_data_unittest.cc View 1 chunk +0 lines, -184 lines 0 comments Download
M chrome/browser/chromeos/extensions/networking_private_api.cc View 2 chunks +1 line, -2 lines 0 comments Download
D chrome/browser/chromeos/net/managed_network_configuration_handler.h View 1 chunk +0 lines, -121 lines 0 comments Download
D chrome/browser/chromeos/net/managed_network_configuration_handler.cc View 1 chunk +0 lines, -206 lines 0 comments Download
M chrome/browser/chromeos/net/onc_utils.h View 1 2 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/net/onc_utils.cc View 1 2 2 chunks +0 lines, -97 lines 0 comments Download
M chrome/browser/chromeos/net/onc_utils_unittest.cc View 1 2 2 chunks +1 line, -39 lines 0 comments Download
M chrome/browser/chromeos/options/network_config_view.h View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/options/network_config_view.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/options/vpn_config_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/options/wifi_config_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/policy/configuration_policy_handler_chromeos.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/network_configuration_updater.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/proxy_config_service_impl.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options/chromeos/internet_options_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 3 chunks +4 lines, -6 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +1 line, -1 line 0 comments Download
D chrome/test/data/chromeos/net/uidata_for_l2tpipsec_clientcert.json View 1 2 1 chunk +0 lines, -19 lines 0 comments Download
D chrome/test/data/chromeos/net/uidata_for_openvpn_clientcert.json View 1 2 1 chunk +0 lines, -19 lines 0 comments Download
D chrome/test/data/chromeos/net/uidata_for_wifi_clientcert.json View 1 2 1 chunk +0 lines, -13 lines 0 comments Download
D chrome/test/data/chromeos/net/uidata_for_wifi_clientref.json View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
D chrome/test/data/chromeos/net/uidata_for_wifi_psk.json View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M chromeos/chromeos.gyp View 3 chunks +7 lines, -0 lines 0 comments Download
A + chromeos/network/certificate_pattern.h View 5 chunks +6 lines, -22 lines 0 comments Download
A + chromeos/network/certificate_pattern.cc View 7 chunks +14 lines, -186 lines 0 comments Download
A + chromeos/network/managed_network_configuration_handler.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + chromeos/network/managed_network_configuration_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chromeos/network/network_ui_data.h View 1 2 3 chunks +24 lines, -63 lines 0 comments Download
A + chromeos/network/network_ui_data.cc View 1 2 3 7 chunks +103 lines, -116 lines 0 comments Download
A + chromeos/network/network_ui_data_unittest.cc View 1 2 3 4 chunks +38 lines, -106 lines 0 comments Download
A + chromeos/test/data/network/uidata_for_l2tpipsec_clientcert.json View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + chromeos/test/data/network/uidata_for_openvpn_clientcert.json View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + chromeos/test/data/network/uidata_for_wifi_clientcert.json View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + chromeos/test/data/network/uidata_for_wifi_clientref.json View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + chromeos/test/data/network/uidata_for_wifi_psk.json View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
pneubeck (no reviews)
Hi Greg and Steven, you might like this one. @Greg, please review. Thanks! @Steven, I'll ...
7 years, 8 months ago (2013-04-08 08:22:06 UTC) #1
gauravsh
On 2013/04/08 08:22:06, pneubeck wrote: > Hi Greg and Steven, you might like this one. ...
7 years, 8 months ago (2013-04-08 16:56:20 UTC) #2
Greg Spencer (Chromium)
LGTM. Thanks for cleaning this up!
7 years, 8 months ago (2013-04-08 18:05:09 UTC) #3
stevenjb
Nice cleanup. LGTM. https://codereview.chromium.org/13454006/diff/11001/chromeos/network/network_ui_data.cc File chromeos/network/network_ui_data.cc (right): https://codereview.chromium.org/13454006/diff/11001/chromeos/network/network_ui_data.cc#newcode86 chromeos/network/network_ui_data.cc:86: !certificate_pattern_.Empty())); Is this logically not possible, ...
7 years, 8 months ago (2013-04-08 19:22:33 UTC) #4
pneubeck (no reviews)
@Jochen, please lgtm the change to chrome/chrome_browser_chromeos.gypi Thanks. https://codereview.chromium.org/13454006/diff/11001/chromeos/network/network_ui_data.cc File chromeos/network/network_ui_data.cc (right): https://codereview.chromium.org/13454006/diff/11001/chromeos/network/network_ui_data.cc#newcode86 chromeos/network/network_ui_data.cc:86: !certificate_pattern_.Empty())); ...
7 years, 8 months ago (2013-04-10 08:59:22 UTC) #5
jochen (gone - plz use gerrit)
lgtm
7 years, 8 months ago (2013-04-10 09:11:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pneubeck@chromium.org/13454006/28001
7 years, 8 months ago (2013-04-10 09:12:01 UTC) #7
commit-bot: I haz the power
7 years, 8 months ago (2013-04-10 11:08:19 UTC) #8
Message was sent while issue was closed.
Change committed as 193364

Powered by Google App Engine
This is Rietveld 408576698