Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 13450006: Support new methods to replace GetResourceList on DriveScheduler. (Closed)

Created:
7 years, 8 months ago by hidehiko
Modified:
7 years, 8 months ago
Reviewers:
hashimoto, kinaba
CC:
chromium-reviews, tfarina, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Support new methods to replace GetResourceList on DriveScheduler. This CL adds new methods into DriveScheduler, which will replace GetResourceList. BUG=160932 TEST=Ran unit_tests --gtest_filter=DriveScheduler* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193349

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+287 lines, -4 lines) Patch
M chrome/browser/chromeos/drive/drive_scheduler.h View 1 3 chunks +51 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_scheduler.cc View 1 3 chunks +124 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_scheduler_unittest.cc View 1 2 chunks +112 lines, -1 line 0 comments Download

Messages

Total messages: 17 (0 generated)
hidehiko
Thank you for your review in advance, - hidehiko
7 years, 8 months ago (2013-04-05 08:41:27 UTC) #1
kinaba
lgtm
7 years, 8 months ago (2013-04-05 09:26:03 UTC) #2
hashimoto
lgtm
7 years, 8 months ago (2013-04-05 09:29:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/13450006/5001
7 years, 8 months ago (2013-04-08 08:41:03 UTC) #4
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-08 08:49:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/13450006/5001
7 years, 8 months ago (2013-04-08 09:47:24 UTC) #6
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-08 09:51:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/13450006/19001
7 years, 8 months ago (2013-04-09 11:16:35 UTC) #8
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=101038
7 years, 8 months ago (2013-04-09 12:09:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/13450006/19001
7 years, 8 months ago (2013-04-09 12:15:02 UTC) #10
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=101058
7 years, 8 months ago (2013-04-09 13:01:46 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/13450006/19001
7 years, 8 months ago (2013-04-09 17:08:19 UTC) #12
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=101199
7 years, 8 months ago (2013-04-09 17:59:11 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/13450006/19001
7 years, 8 months ago (2013-04-09 18:11:42 UTC) #14
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=101242
7 years, 8 months ago (2013-04-09 19:07:39 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/13450006/34001
7 years, 8 months ago (2013-04-10 05:02:46 UTC) #16
commit-bot: I haz the power
7 years, 8 months ago (2013-04-10 08:55:38 UTC) #17
Message was sent while issue was closed. 
Change committed as 193349

Powered by Google App Engine
This is Rietveld 408576698