Issue 13448003: Narrow the ownership of DriveUploader from DriveSystemService to DriveScheduler.

Issue 13448003: Narrow the ownership of DriveUploader from DriveSystemService to DriveScheduler. (Closed)

Created:
7 years, 8 months ago by kinaba

Modified:
7 years, 8 months ago

Reviewers:
Zachary Kuznia

CC:
chromium-reviews, nkostylev+watch_chromium.org, tzik+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, kinuko+watch, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Narrow the ownership of DriveUploader from DriveSystemService to DriveScheduler. Noone else is using Uploader in the Drive implementation. All Drive operations should be under the control of Scheduler. BUG=147358 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192477

Patch Set 1 : #

Patch Set 2 : Rebase. #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -37 lines)			Patch
M	chrome/browser/chromeos/drive/drive_file_system.h	View	1	3 chunks	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/chromeos/drive/drive_file_system.cc	View	1	4 chunks	+1 line, -5 lines	0 comments	Download
M	chrome/browser/chromeos/drive/drive_file_system_unittest.cc	View	1	4 chunks	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/drive/drive_scheduler.h	View	1	2 chunks	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/drive/drive_scheduler.cc	View	1	1 chunk	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/drive/drive_scheduler_unittest.cc	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/chromeos/drive/drive_system_service.h	View		3 chunks	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/drive/drive_system_service.cc	View		3 chunks	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_system/create_directory_operation_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/drive/file_system/drive_operations.h	View		2 chunks	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_system/drive_operations.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/drive/search_metadata_unittest.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/drive/stale_cache_files_remover_unittest.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kinaba

PTAL. This should land on top of https://codereview.chromium.org/13446003/ and https://codereview.chromium.org/13445002/.

7 years, 8 months ago (2013-04-02 08:50:08 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/13448003/10001

7 years, 8 months ago (2013-04-05 00:15:53 UTC) #3

Message was sent while issue was closed.

Change committed as 192477

Expand Messages | Collapse Messages