Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1343873004: Add IsolatedScriptTest (Closed)

Created:
5 years, 3 months ago by nednguyen
Modified:
5 years, 1 month ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org, stip+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Add IsolatedScriptTest BUG=

Patch Set 1 #

Total comments: 3

Patch Set 2 : Address review comments #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -0 lines) Patch
M masters/master.tryserver.chromium.linux/master.cfg View 1 chunk +7 lines, -0 lines 0 comments Download
M masters/master.tryserver.chromium.linux/slaves.cfg View 1 1 chunk +1 line, -0 lines 0 comments Download
A run_recipe.sh View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/chromium_linux.py View 1 11 chunks +31 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/steps.py View 1 2 1 chunk +111 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.py View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
nednguyen
5 years, 3 months ago (2015-09-15 01:23:18 UTC) #2
Ken Russell (switch to Gerrit)
https://codereview.chromium.org/1343873004/diff/1/scripts/slave/recipe_modules/chromium_tests/steps.py File scripts/slave/recipe_modules/chromium_tests/steps.py (right): https://codereview.chromium.org/1343873004/diff/1/scripts/slave/recipe_modules/chromium_tests/steps.py#newcode855 scripts/slave/recipe_modules/chromium_tests/steps.py:855: def isolate_target(self): I think we need to override the ...
5 years, 3 months ago (2015-09-15 01:41:16 UTC) #3
iannucci
https://chromiumcodereview.appspot.com/1343873004/diff/1/scripts/slave/recipe_modules/chromium_tests/steps.py File scripts/slave/recipe_modules/chromium_tests/steps.py (right): https://chromiumcodereview.appspot.com/1343873004/diff/1/scripts/slave/recipe_modules/chromium_tests/steps.py#newcode904 scripts/slave/recipe_modules/chromium_tests/steps.py:904: self._test_runs[suffix] = api.step.active_result talked to kbr. I think what ...
5 years, 3 months ago (2015-09-17 00:49:48 UTC) #5
Ken Russell (switch to Gerrit)
5 years, 3 months ago (2015-09-17 01:19:31 UTC) #6 
https://codereview.chromium.org/1343873004/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/chromium_tests/steps.py (right):

https://codereview.chromium.org/1343873004/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_tests/steps.py:888: gtest_results_file =
api.test_utils.gtest_results(add_json_log=False)
We should use api.json.output() here and a similar step_test_data to what
ScriptTest uses. I didn't realize this, but the use of placeholders like
api.json.output() causes properties to be added to the step's active_result
corresponding to where the placeholder came from. So using api.json.output()
results in api.step.active_result.json.output being synthesized. The mismatch
between the use of api.test_utils.gtest_results and api.step.active_result.json
is what's breaking this code.

Powered by Google App Engine
This is Rietveld 408576698