Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1329)

Unified Diff: build/android/javac.py

Issue 13432002: Add input content checking to some build scripts (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/android/javac.py
diff --git a/build/android/javac.py b/build/android/javac.py
deleted file mode 100755
index 2b19185c1b2e1c852adfe0228e6770fb38752adf..0000000000000000000000000000000000000000
--- a/build/android/javac.py
+++ /dev/null
@@ -1,87 +0,0 @@
-#!/usr/bin/env python
-#
-# Copyright 2013 The Chromium Authors. All rights reserved.
-# Use of this source code is governed by a BSD-style license that can be
-# found in the LICENSE file.
-
-import fnmatch
-import optparse
-import os
-import sys
-
-from pylib import build_utils
-
-def DoJavac(options):
- output_dir = options.output_dir
-
- src_dirs = build_utils.ParseGypList(options.src_dirs)
- java_files = build_utils.FindInDirectories(src_dirs, '*.java')
- if options.javac_includes:
- javac_includes = build_utils.ParseGypList(options.javac_includes)
- filtered_java_files = []
- for f in java_files:
- for include in javac_includes:
- if fnmatch.fnmatch(f, include):
- filtered_java_files.append(f)
- break
- java_files = filtered_java_files
-
- # Compiling guava with certain orderings of input files causes a compiler
- # crash... Sorted order works, so use that.
- # See https://code.google.com/p/guava-libraries/issues/detail?id=950
- java_files.sort()
-
- classpath = build_utils.ParseGypList(options.classpath)
-
- # Delete the classes directory. This ensures that all .class files in the
- # output are actually from the input .java files. For example, if a .java
- # file is deleted or an inner class is removed, the classes directory should
- # not contain the corresponding old .class file after running this action.
- build_utils.DeleteDirectory(output_dir)
- build_utils.MakeDirectory(output_dir)
-
- cmd = [
- 'javac',
- '-g',
- '-source', '1.5',
- '-target', '1.5',
- '-classpath', ':'.join(classpath),
- '-d', output_dir]
-
- # Only output Java warnings for chromium code
- if options.chromium_code:
- cmd += ['-Xlint:unchecked']
- else:
- cmd += [# Suppress "Sun proprietary API" warnings. See: goo.gl/OYxUM
- '-XDignore.symbol.file']
-
- build_utils.CheckCallDie(cmd + java_files)
-
-def main(argv):
- parser = optparse.OptionParser()
- parser.add_option('--src-dirs', help='Directories containing java files.')
- parser.add_option('--javac-includes',
- help='A list of file patterns. If provided, only java files that match' +
- 'one of the patterns will be compiled.')
- parser.add_option('--classpath', help='Classpath for javac.')
- parser.add_option('--output-dir', help='Directory for javac output.')
- parser.add_option('--stamp', help='Path to touch on success.')
- parser.add_option('--chromium-code', type='int', help='Whether code being '
- 'compiled should be built with stricter warnings for '
- 'chromium code.')
-
- # TODO(newt): remove this once http://crbug.com/177552 is fixed in ninja.
- parser.add_option('--ignore', help='Ignored.')
-
- options, _ = parser.parse_args()
-
- DoJavac(options)
-
- if options.stamp:
- build_utils.Touch(options.stamp)
-
-
-if __name__ == '__main__':
- sys.exit(main(sys.argv))
-
-

Powered by Google App Engine
This is Rietveld 408576698