Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(658)

Issue 13432002: Add input content checking to some build scripts (Closed)

Created:
7 years, 8 months ago by cjhopman
Modified:
7 years, 8 months ago
Reviewers:
Yaron
CC:
chromium-reviews, klundberg+watch_chromium.org, frankf+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org
Visibility:
Public.

Description

Add input content checking to some build scripts Some build steps, particularly javac, have really loose input rules. I.e. javac steps are re-built when any input jar changes. Often, this leads to unnecessary rebuilds of all the following steps. Other build tools (ninja, goma), will check the contents of the inputs to a step, and if those inputs haven't changed that tool doesn't actually re-run the command for creating the output. This change brings that same benefit to some of the Android python build scripts. Particularly those that will save a significant amount of time by adding input content checks. The checking checks both the input files and the command that will be run. It compares this against a stored md5 digest. If it has not changed, then the output does not need to be recreated (though it is still touched to trigger following steps). BUG=158821 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192265

Patch Set 1 : #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -199 lines) Patch
D build/android/dex.py View 1 chunk +0 lines, -40 lines 0 comments Download
A + build/android/gyp/dex.py View 1 chunk +14 lines, -1 line 2 comments Download
A + build/android/gyp/jar.py View 2 chunks +17 lines, -3 lines 0 comments Download
A + build/android/gyp/javac.py View 1 chunk +3 lines, -0 lines 2 comments Download
M build/android/gyp/push_libraries.py View 2 chunks +12 lines, -2 lines 0 comments Download
A + build/android/gyp/util/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A build/android/gyp/util/md5_check.py View 1 chunk +52 lines, -0 lines 0 comments Download
D build/android/jar.py View 1 chunk +0 lines, -53 lines 0 comments Download
D build/android/javac.py View 1 chunk +0 lines, -87 lines 0 comments Download
M build/java.gypi View 4 chunks +8 lines, -6 lines 0 comments Download
M build/java_apk.gypi View 6 chunks +9 lines, -6 lines 2 comments Download
M build/java_prebuilt.gypi View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
cjhopman
7 years, 8 months ago (2013-04-02 23:24:09 UTC) #1
Yaron
lgtm https://codereview.chromium.org/13432002/diff/16004/build/android/gyp/dex.py File build/android/gyp/dex.py (right): https://codereview.chromium.org/13432002/diff/16004/build/android/gyp/dex.py#newcode17 build/android/gyp/dex.py:17: from pylib import build_utils Is build_utils moving to ...
7 years, 8 months ago (2013-04-03 22:05:35 UTC) #2
cjhopman
https://codereview.chromium.org/13432002/diff/16004/build/android/gyp/dex.py File build/android/gyp/dex.py (right): https://codereview.chromium.org/13432002/diff/16004/build/android/gyp/dex.py#newcode17 build/android/gyp/dex.py:17: from pylib import build_utils On 2013/04/03 22:05:35, Yaron wrote: ...
7 years, 8 months ago (2013-04-03 22:17:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/13432002/16004
7 years, 8 months ago (2013-04-03 22:28:17 UTC) #4
commit-bot: I haz the power
7 years, 8 months ago (2013-04-04 09:35:53 UTC) #5
Message was sent while issue was closed.
Change committed as 192265

Powered by Google App Engine
This is Rietveld 408576698