Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 13421008: Fix menu for 'disable extension'. (Closed)

Created:
7 years, 8 months ago by Jun Mukai
Modified:
7 years, 8 months ago
Reviewers:
miket_OOO, dharcourt, sky
CC:
chromium-reviews, Aaron Boodman, jshin+watch_chromium.org, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Fix menu for 'disable extension'. - The 'display_source' field should specify the extension's name. It seems to be the field for such purpose (see DisplayNameForOrigin() method in DesktopNotificationService for example) - Fix the strings of 'disable extension' menu item to show the extension's name. - Fix the behavior of 'DisableExtension' in MessageCenterNotificationManager. It should not disable the extension itself, rather disable the notification ability for the extension. BUG=226185 TEST=manually TBR=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192907

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -7 lines) Patch
M chrome/browser/extensions/api/notifications/notifications_api.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/notifications/message_center_notification_manager.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M ui/base/strings/ui_strings.grd View 1 chunk +1 line, -1 line 0 comments Download
M ui/message_center/views/message_view.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Jun Mukai
7 years, 8 months ago (2013-04-04 01:20:09 UTC) #1
dharcourt
lgtm
7 years, 8 months ago (2013-04-05 15:47:18 UTC) #2
Jun Mukai
miket, please review this as the OWNER of c/b/extensions
7 years, 8 months ago (2013-04-06 01:36:19 UTC) #3
miket_OOO
On 2013/04/06 01:36:19, Jun Mukai wrote: > miket, please review this as the OWNER of ...
7 years, 8 months ago (2013-04-08 16:42:08 UTC) #4
Jun Mukai
adding TBR=sky for ui/base/ui_strings.grd change. The new string is provided in the issue page.
7 years, 8 months ago (2013-04-08 17:02:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/13421008/1
7 years, 8 months ago (2013-04-08 17:02:57 UTC) #6
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-08 17:11:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/13421008/1
7 years, 8 months ago (2013-04-08 20:56:10 UTC) #8
commit-bot: I haz the power
7 years, 8 months ago (2013-04-08 21:31:48 UTC) #9
Message was sent while issue was closed.
Change committed as 192907

Powered by Google App Engine
This is Rietveld 408576698