Issue 13406005: Stop casting uintptr_t* to int*.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13406005: Stop casting uintptr_t* to int*. (Closed)

Created:
7 years, 8 months ago by Avi (use Gerrit)

Modified:
7 years, 8 months ago

Reviewers:
dmac, Mattias Nissler (ping if slow)

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Stop casting uintptr_t* to int*. BUG=130980 TEST=FilePathWatcherTest passes on 64 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=191913

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -24 lines)			Patch
	M	base/files/file_path_watcher.h	View	1 2	2 chunks	+1 line, -3 lines	0 comments	Download
	M	base/files/file_path_watcher_kqueue.cc	View	1 2	12 chunks	+28 lines, -21 lines	0 comments	Download

Total messages: 4 (0 generated)

Mattias Nissler (ping if slow)

LGTM, these casts were definitely wrong. dmaclach@ is the original author of this and might ...

7 years, 8 months ago (2013-04-02 08:42:11 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/13406005/9001

7 years, 8 months ago (2013-04-02 14:02:57 UTC) #3

Message was sent while issue was closed.

Change committed as 191913