Issue 13403004: Make maxlen configurable in PanProjectChecks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13403004: Make maxlen configurable in PanProjectChecks (Closed)

Created:
7 years, 8 months ago by jamesr

Modified:
7 years, 8 months ago

Reviewers:
Dirk Pranke

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Visibility:
Public.

More Reviews

Description

Make maxlen configurable in PanProjectChecks Blink wants to override the maxlen which is currently configurable in CheckLongLines but not in PanProjectChecks. This exposes the parameter on PanProjectChecks. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=192394

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -6 lines)			Patch
	M	presubmit_canned_checks.py	View		3 chunks	+3 lines, -3 lines	0 comments	Download
	M	tests/presubmit_unittest.py	View		1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/13403004/1

7 years, 8 months ago (2013-04-04 21:42:15 UTC) #3

Message was sent while issue was closed.

Change committed as 192394

Expand Messages | Collapse Messages