chromeos: Replace resource ID in drive URL with path

chromeos: Replace resource ID in drive URL with path

BUG=175948
TEST=Open a .txt file in Google Drive directory from both Files.app and Ctrl-O


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192541

[hidehiko, 2013-04-04 08:02:41]

On 2013/04/04 07:52:40, hashimoto wrote:

I just want to clarify. IIRC, this CL should be submitted after Haruki's
"drive/other" path work, right?

[hashimoto, 2013-04-04 08:04:45]

On 2013/04/04 08:02:41, hidehiko wrote:
> On 2013/04/04 07:52:40, hashimoto wrote:
> 
> I just want to clarify. IIRC, this CL should be submitted after Haruki's
> "drive/other" path work, right?

I don't think so.
DriveFileSystem's methods and util::ExtractDrivePath() will absorb the changes
in paths.

[kinaba, 2013-04-04 08:13:01]

https://codereview.chromium.org/13401003/diff/6001/chrome/browser/chromeos/dr...
File chrome/browser/chromeos/drive/drive_file_system_util.cc (right):

https://codereview.chromium.org/13401003/diff/6001/chrome/browser/chromeos/dr...
chrome/browser/chromeos/drive/drive_file_system_util.cc:183:
path.AsUTF8Unsafe().c_str()));
Don't we need to, say, net::EscapeUrlEncodedData and probably decode in the URL
request job?
The document of GURL says "The URL will be ASCII except the reference fragment,
which may be UTF-8."

[hashimoto, 2013-04-04 09:19:32]

https://codereview.chromium.org/13401003/diff/6001/chrome/browser/chromeos/dr...
File chrome/browser/chromeos/drive/drive_file_system_util.cc (right):

https://codereview.chromium.org/13401003/diff/6001/chrome/browser/chromeos/dr...
chrome/browser/chromeos/drive/drive_file_system_util.cc:183:
path.AsUTF8Unsafe().c_str()));
On 2013/04/04 08:13:01, kinaba wrote:
> Don't we need to, say, net::EscapeUrlEncodedData and probably decode in the
URL
> request job?
> The document of GURL says "The URL will be ASCII except the reference
fragment,
> which may be UTF-8."

Oh, I should have tested with files with names consisting non ASCII characters.
Added unescape code to drive_url_request_job.cc.
Escape is already taken care by GURL::GURL which accepts UTF-8 string as its
input.

[kinaba, 2013-04-05 02:05:23]

lgtm

[hashimoto, 2013-04-05 04:10:10]

Renamed GetFileResourceURL to FilePathToDriveURL. (like FilePathToFileURL in
net/base/net_util.h)
Renamed GetFilePathFromURL to DriveURLToFilePath and moved it from
drive_url_request_job.cc to drive_file_system_util.cc.
Add tests for FilePathToDriveURL and DriveURLToFilePath.

PTAL

[kinaba, 2013-04-05 04:57:33]

lgtm

[hidehiko, 2013-04-05 06:29:57]

lgtm

[commit-bot: I haz the power, 2013-04-05 07:32:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hashimoto@chromium.org/13401003/35001

[commit-bot: I haz the power, 2013-04-05 10:32:28]

Change committed as 192541