Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2849)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java

Issue 1339613004: Add Data Reduction Proxy card to Clank FRE in EM (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nits Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java
index 40d3d2d0da3e6925db4006562ef40fb29dc153ef..377fd77996780b91615d6353e32c9739356871d5 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java
@@ -14,6 +14,7 @@ import android.text.TextUtils;
import android.util.Log;
import org.chromium.base.ApplicationStatus;
+import org.chromium.base.FieldTrialList;
import org.chromium.base.VisibleForTesting;
import org.chromium.base.library_loader.ProcessInitException;
import org.chromium.base.metrics.RecordHistogram;
@@ -21,6 +22,9 @@ import org.chromium.base.metrics.RecordUserAction;
import org.chromium.chrome.R;
import org.chromium.chrome.browser.ChromeApplication;
import org.chromium.chrome.browser.EmbedContentViewActivity;
+import org.chromium.chrome.browser.net.spdyproxy.DataReductionProxySettings;
+import org.chromium.chrome.browser.preferences.datareduction.DataReductionPromoScreen;
+import org.chromium.chrome.browser.preferences.datareduction.DataReductionProxyUma;
import org.chromium.chrome.browser.profiles.Profile;
import java.lang.ref.WeakReference;
@@ -100,6 +104,11 @@ public class FirstRunActivity extends AppCompatActivity implements FirstRunPageD
// An optional welcome page.
if (mShowWelcomePage) mPages.add(pageOf(ToSAndUMAFirstRunFragment.class));
+ // An optional Data Saver page.
+ if (FieldTrialList.findFullName("DataReductionProxyFREPromo").equals("Enabled")) {
Alexei Svitkine (slow) 2015/09/28 18:52:08 Our best practice is to use startsWith(). This all
megjablon 2015/09/28 23:37:28 Done.
+ mPages.add(pageOf(DataReductionProxyFirstRunFragment.class));
+ }
+
// An optional sign-in page.
if (mFreProperties.getBoolean(SHOW_SIGNIN_PAGE)) {
mPages.add(pageOf(AccountFirstRunFragment.class));
@@ -288,6 +297,17 @@ public class FirstRunActivity extends AppCompatActivity implements FirstRunPageD
startActivity(originalIntent);
}
+ if (DataReductionPromoScreen
+ .getDisplayedDataReductionPromo(getApplicationContext())) {
+ if (DataReductionProxySettings.getInstance().isDataReductionProxyEnabled()) {
+ DataReductionProxyUma
+ .dataReductionProxyUIAction(DataReductionProxyUma.ACTION_FRE_ENABLED);
+ } else {
+ DataReductionProxyUma
+ .dataReductionProxyUIAction(DataReductionProxyUma.ACTION_FRE_DISABLED);
+ }
+ }
+
Intent resultData = new Intent();
resultData.putExtras(mFreProperties);
finishAllFREActivities(Activity.RESULT_OK, resultData);

Powered by Google App Engine
This is Rietveld 408576698