Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 13392014: Move c/b/webdata/ code to components/webdata/ (Closed)

Created:
7 years, 8 months ago by Cait (Slow)
Modified:
7 years, 8 months ago
CC:
chromium-reviews, Raman Kakilate, akalin, Raghu Simha, benquan, dhollowa+watch_chromium.org, amit, ahutter, browser-components-watch_chromium.org, dbeam+watch-autofill_chromium.org, grt+watch_chromium.org, robertshield, Dane Wallinga, dyu1, Albert Bodenhamer, estade+watch_chromium.org, markusheintz_, Ilya Sherman, haitaol1, tim (not reviewing)
Visibility:
Public.

Description

Move c/b/webdata/code which does not depend on chrome/ to components/webdata/ Specifically: Moving to components/webdata/autofill: c/b/api/webdata/autofill_web_data.h c/b/webdata/autofill_change.(cc|h) c/b/webdata/autofill_entry.(cc|h) c/b/webdata/autofill_table.(cc|h) c/b/webdata/autofill_web_data_service.(cc|h) moving to components/webdata/common: c/b/api/webdata/web_data_service_base c/b/api/webdata/web_data_service_consumer c/b/api/webdata/web_data_results c/b/webdata/web_data_request_manager c/b/webdata/web_data_service_base c/b/webdata/web_data_service_test_util c/b/webdata/web_database c/b/webdata/web_database_service c/b/webdata/web_database_table c/b/webdata/webdata_constants No change in how Webdata is built (it is still part of chrome_browser). All source files were moved using //tools/git/move_source_file.py, which updates includes of moved files, sorts include order, and updates header guards. The only manual bits of this change were: - Update .gypi files - Update DEPS files TBR=ben@chromium.org TEST=compiles! BUG=181277 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192161

Patch Set 1 #

Total comments: 2

Patch Set 2 : Move other Webdata code too #

Patch Set 3 : Pure merge #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+206 lines, -5072 lines) Patch
D chrome/browser/api/webdata/autofill_web_data.h View 1 chunk +0 lines, -88 lines 0 comments Download
D chrome/browser/api/webdata/web_data_results.h View 1 1 chunk +0 lines, -134 lines 0 comments Download
D chrome/browser/api/webdata/web_data_service_base.h View 1 1 chunk +0 lines, -131 lines 0 comments Download
D chrome/browser/api/webdata/web_data_service_consumer.h View 1 1 chunk +0 lines, -26 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_remover.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/diagnostics/sqlite_diagnostics.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/password_manager/password_store_win_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_service_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/autofill_data_type_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/autofill_data_type_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/autofill_data_type_controller_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/autofill_profile_data_type_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/autofill_profile_data_type_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_components_factory_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_components_factory_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_autofill_unittest.cc View 1 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/sync/test/integration/autofill_helper.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/sync/test/integration/performance/autofill_sync_perf_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/two_client_autofill_sync_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/webdata/autocomplete_syncable_service.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/webdata/autocomplete_syncable_service.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
D chrome/browser/webdata/autofill_change.h View 1 chunk +0 lines, -72 lines 0 comments Download
D chrome/browser/webdata/autofill_change.cc View 1 chunk +0 lines, -34 lines 0 comments Download
D chrome/browser/webdata/autofill_entry.h View 1 chunk +0 lines, -71 lines 0 comments Download
D chrome/browser/webdata/autofill_entry.cc View 1 chunk +0 lines, -125 lines 0 comments Download
M chrome/browser/webdata/autofill_entry_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webdata/autofill_profile_syncable_service.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/webdata/autofill_profile_syncable_service.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/webdata/autofill_profile_syncable_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/webdata/autofill_table.h View 1 1 chunk +0 lines, -366 lines 0 comments Download
D chrome/browser/webdata/autofill_table.cc View 1 1 chunk +0 lines, -2047 lines 0 comments Download
M chrome/browser/webdata/autofill_table_unittest.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
D chrome/browser/webdata/autofill_web_data_service.h View 1 chunk +0 lines, -132 lines 0 comments Download
D chrome/browser/webdata/autofill_web_data_service.cc View 1 chunk +0 lines, -458 lines 0 comments Download
D chrome/browser/webdata/autofill_web_data_service_observer.h View 1 chunk +0 lines, -37 lines 0 comments Download
M chrome/browser/webdata/keyword_table.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webdata/keyword_table.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webdata/keyword_table_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webdata/logins_table.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webdata/logins_table.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webdata/token_service_table.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webdata/token_service_table.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webdata/token_service_table_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webdata/web_apps_table.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webdata/web_apps_table.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webdata/web_apps_table_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/webdata/web_data_request_manager.h View 1 1 chunk +0 lines, -137 lines 0 comments Download
D chrome/browser/webdata/web_data_request_manager.cc View 1 1 chunk +0 lines, -148 lines 0 comments Download
M chrome/browser/webdata/web_data_service.h View 1 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/webdata/web_data_service.cc View 1 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/webdata/web_data_service_base.cc View 1 1 chunk +0 lines, -121 lines 0 comments Download
M chrome/browser/webdata/web_data_service_factory.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webdata/web_data_service_factory.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/webdata/web_data_service_test_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webdata/web_data_service_unittest.cc View 1 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/webdata/web_data_service_win.cc View 1 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/webdata/web_database.h View 1 1 chunk +0 lines, -78 lines 0 comments Download
D chrome/browser/webdata/web_database.cc View 1 1 chunk +0 lines, -173 lines 0 comments Download
M chrome/browser/webdata/web_database_migration_unittest.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
D chrome/browser/webdata/web_database_service.h View 1 1 chunk +0 lines, -106 lines 0 comments Download
D chrome/browser/webdata/web_database_service.cc View 1 1 chunk +0 lines, -287 lines 0 comments Download
D chrome/browser/webdata/web_database_table.h View 1 1 chunk +0 lines, -65 lines 0 comments Download
D chrome/browser/webdata/web_database_table.cc View 1 1 chunk +0 lines, -17 lines 0 comments Download
M chrome/browser/webdata/web_intents_table.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webdata/web_intents_table.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
D chrome/browser/webdata/webdata_constants.h View 1 1 chunk +0 lines, -12 lines 0 comments Download
D chrome/browser/webdata/webdata_constants.cc View 1 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 4 chunks +24 lines, -24 lines 0 comments Download
M chrome_frame/test/delete_chrome_history_test.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M components/autofill/browser/DEPS View 1 3 chunks +1 line, -5 lines 0 comments Download
M components/autofill/browser/autocomplete_history_manager.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M components/autofill/browser/autocomplete_history_manager_unittest.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M components/autofill/browser/autofill_metrics_unittest.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M components/autofill/browser/personal_data_manager.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M components/autofill/browser/personal_data_manager.cc View 2 chunks +1 line, -1 line 0 comments Download
M components/autofill/browser/personal_data_manager_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
A components/webdata/DEPS View 1 1 chunk +10 lines, -0 lines 1 comment Download
A + components/webdata/autofill/autofill_change.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + components/webdata/autofill/autofill_change.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/webdata/autofill/autofill_entry.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/webdata/autofill/autofill_entry.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/webdata/autofill/autofill_table.h View 1 2 chunks +6 lines, -6 lines 0 comments Download
A + components/webdata/autofill/autofill_table.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
A + components/webdata/autofill/autofill_webdata.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
A + components/webdata/autofill/autofill_webdata_service.h View 1 2 chunks +8 lines, -8 lines 0 comments Download
A + components/webdata/autofill/autofill_webdata_service.cc View 1 1 chunk +6 lines, -6 lines 0 comments Download
A + components/webdata/autofill/autofill_webdata_service_observer.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + components/webdata/common/web_data_request_manager.h View 1 2 chunks +6 lines, -6 lines 0 comments Download
A + components/webdata/common/web_data_request_manager.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + components/webdata/common/web_data_results.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + components/webdata/common/web_data_service_base.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + components/webdata/common/web_data_service_base.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + components/webdata/common/web_data_service_consumer.h View 1 2 chunks +5 lines, -5 lines 0 comments Download
A + components/webdata/common/web_database.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
A + components/webdata/common/web_database.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + components/webdata/common/web_database_service.h View 1 3 chunks +5 lines, -5 lines 0 comments Download
A + components/webdata/common/web_database_service.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
A + components/webdata/common/web_database_table.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + components/webdata/common/web_database_table.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + components/webdata/common/webdata_constants.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + components/webdata/common/webdata_constants.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
Cait (Slow)
This CL starts the process of moving the componentizable bits of WebData into components/ by ...
7 years, 8 months ago (2013-04-01 17:20:26 UTC) #1
kaiwang
Hi Cait, you'll move the rest common webdata code to components/webdata right? E.g. web_data_service_base Please ...
7 years, 8 months ago (2013-04-01 18:09:11 UTC) #2
dhollowa
Rubber stamp LGTM.
7 years, 8 months ago (2013-04-01 18:13:19 UTC) #3
Cait (Slow)
Patchset 2 moves the rest of the webdata code and fixes the DEPS issues. https://codereview.chromium.org/13392014/diff/1/components/webdata/DEPS ...
7 years, 8 months ago (2013-04-02 17:59:23 UTC) #4
kaiwang
lgtm
7 years, 8 months ago (2013-04-03 18:10:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caitkp@chromium.org/13392014/9001
7 years, 8 months ago (2013-04-03 20:03:27 UTC) #6
commit-bot: I haz the power
Change committed as 192161
7 years, 8 months ago (2013-04-03 21:24:12 UTC) #7
Jói
LGTM Recommend moving the unit tests that we expect will go to //components/webdata soon as ...
7 years, 8 months ago (2013-04-04 13:50:06 UTC) #8
Jói
7 years, 8 months ago (2013-04-04 13:51:23 UTC) #9
Message was sent while issue was closed.
https://codereview.chromium.org/13392014/diff/9001/components/webdata/DEPS
File components/webdata/DEPS (right):

https://codereview.chromium.org/13392014/diff/9001/components/webdata/DEPS#ne...
components/webdata/DEPS:3: # //components/webdata and not depend on //chrome),
so we have these basic
Nit: This comment should be updated; can do it in the same change as updating to
build the production code as a component.

Powered by Google App Engine
This is Rietveld 408576698