Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Unified Diff: components/visitedlink/test/visitedlink_perftest.cc

Issue 13392002: Add perf tests target to components. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/components_tests.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/visitedlink/test/visitedlink_perftest.cc
diff --git a/components/visitedlink/test/visitedlink_perftest.cc b/components/visitedlink/test/visitedlink_perftest.cc
index c9577f17fee9020244c0222204c651db456e47e3..521cc649dc4e73477448d3fa5cbcd74dc5a54064 100644
--- a/components/visitedlink/test/visitedlink_perftest.cc
+++ b/components/visitedlink/test/visitedlink_perftest.cc
@@ -40,11 +40,6 @@ class DummyVisitedLinkEventListener : public VisitedLinkMaster::Listener {
virtual void NewTable(base::SharedMemory* table) OVERRIDE {}
virtual void Add(VisitedLinkCommon::Fingerprint) OVERRIDE {}
virtual void Reset() OVERRIDE {}
-
- static DummyVisitedLinkEventListener* GetInstance() {
- static DummyVisitedLinkEventListener instance;
- return &instance;
- }
};
@@ -84,7 +79,7 @@ class VisitedLink : public testing::Test {
// useful to make another set of tests to test these things in isolation.
TEST_F(VisitedLink, TestAddAndQuery) {
// init
- VisitedLinkMaster master(DummyVisitedLinkEventListener::GetInstance(),
+ VisitedLinkMaster master(new DummyVisitedLinkEventListener(),
boliu 2013/03/31 17:30:03 nit: No need for () here and below
NULL, true, true, db_path_, 0);
ASSERT_TRUE(master.Init());
@@ -115,7 +110,7 @@ TEST_F(VisitedLink, TestLoad) {
{
PerfTimeLogger table_initialization_timer("Table_initialization");
- VisitedLinkMaster master(DummyVisitedLinkEventListener::GetInstance(),
+ VisitedLinkMaster master(new DummyVisitedLinkEventListener(),
NULL, true, true, db_path_, 0);
// time init with empty table
@@ -153,7 +148,7 @@ TEST_F(VisitedLink, TestLoad) {
{
PerfTimer cold_timer;
- VisitedLinkMaster master(DummyVisitedLinkEventListener::GetInstance(),
+ VisitedLinkMaster master(new DummyVisitedLinkEventListener(),
NULL,
true,
true,
@@ -170,7 +165,7 @@ TEST_F(VisitedLink, TestLoad) {
{
PerfTimer hot_timer;
- VisitedLinkMaster master(DummyVisitedLinkEventListener::GetInstance(),
+ VisitedLinkMaster master(new DummyVisitedLinkEventListener(),
NULL,
true,
true,
« no previous file with comments | « components/components_tests.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698