Issue 13358002: [Coverity] Fix pass by value error in FaviconUtil::SelectFaviconFramesFromPNGs().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13358002: [Coverity] Fix pass by value error in FaviconUtil::SelectFaviconFramesFromPNGs(). (Closed)

Created:
7 years, 8 months ago by kmadhusu

Modified:
7 years, 8 months ago

Reviewers:
stevenjb, Cait (Slow)

CC:
chromium-reviews, browser-components-watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

[Coverity] Fix pass by value error in FaviconUtil::SelectFaviconFramesFromPNGs(). CID=105999 BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192648

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	chrome/browser/favicon/favicon_util.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome/browser/favicon/favicon_util.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 8 (0 generated)

Cait (Slow)

Apologies for the delay. lgtm you'll need another reviewer to land it though, as I ...

7 years, 8 months ago (2013-04-05 20:45:55 UTC) #3

kmadhusu

On 2013/04/05 20:45:55, caitkp wrote: > Apologies for the delay. > > lgtm > > ...

7 years, 8 months ago (2013-04-05 20:49:32 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kmadhusu@chromium.org/13358002/1

7 years, 8 months ago (2013-04-05 20:56:47 UTC) #7

Message was sent while issue was closed.

Change committed as 192648