ppapi/native_client/src/untrusted/irt_stub/BUILD.gn - Issue 1333673002: Build PPAPI NaCl Glibc tests with GN

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/native_client/src/untrusted/irt_stub/BUILD.gn

Issue 1333673002: Build PPAPI NaCl Glibc tests with GN (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ppapi/native_client/src/untrusted/irt_stub/BUILD.gn

diff --git a/ppapi/native_client/src/untrusted/irt_stub/BUILD.gn b/ppapi/native_client/src/untrusted/irt_stub/BUILD.gn

index 484145f49e7cc9477c3c0d7065725f166a998994..9b4febb6acd9bfa9029c7bf37fc3096bb3ac1081 100644

--- a/ppapi/native_client/src/untrusted/irt_stub/BUILD.gn

+++ b/ppapi/native_client/src/untrusted/irt_stub/BUILD.gn

@@ -5,8 +5,6 @@

assert(is_nacl,

"These targets must only be built using the untrusted NaCl toolchains.")

-# TODO(sbc): Make sure this library gets built with -fPIC. Right now it

-# doesn't seem that is built at all.

source_set("ppapi_stub_lib") {

sources = [

"plugin_main_irt.c",

@@ -14,4 +12,8 @@ source_set("ppapi_stub_lib") {

"ppapi_plugin_start.c",

"thread_creator.c",

]

+ cflags = [ "-fPIC" ]

+ deps = [

+ "//build/config/nacl:nacl_base",

+ ]

}