Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1333663002: Add wjmaclean@chromium.org to various guest_view/web_view OWNERS. (Closed)

Created:
5 years, 3 months ago by wjmaclean
Modified:
5 years, 3 months ago
Reviewers:
Fady Samuel
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, darin-cc_chromium.org, jam, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add wjmaclean@chromium.org to various guest_view/web_view OWNERS. BUG=none Committed: https://crrev.com/a9c95f121739e58969777f611ae9248cd2809765 Cr-Commit-Position: refs/heads/master@{#347966}

Patch Set 1 #

Patch Set 2 : Don't change extensions/common/api/OWNERS. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M chrome/browser/apps/guest_view/OWNERS View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/web_view/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/data/extensions/platform_apps/web_view/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M components/guest_view/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M components/guest_view/common/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M components/guest_view/renderer/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/browser_plugin/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/browser/guest_view/OWNERS View 1 chunk +2 lines, -1 line 0 comments Download
M extensions/common/guest_view/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/renderer/guest_view/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/renderer/resources/guest_view/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/test/data/web_view/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Issue 1047683002 Patch 1

Messages

Total messages: 8 (2 generated)
wjmaclean
Let me know if this list looks ok.
5 years, 3 months ago (2015-09-09 16:23:37 UTC) #2
Fady Samuel
lgtm
5 years, 3 months ago (2015-09-09 16:30:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1333663002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1333663002/20001
5 years, 3 months ago (2015-09-09 16:47:50 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-09 18:43:20 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/a9c95f121739e58969777f611ae9248cd2809765 Cr-Commit-Position: refs/heads/master@{#347966}
5 years, 3 months ago (2015-09-09 18:44:06 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:01:28 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/a9c95f121739e58969777f611ae9248cd2809765
Cr-Commit-Position: refs/heads/master@{#347966}

Powered by Google App Engine
This is Rietveld 408576698