Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 13334011: Add Xfermode bench. Also clear before rendering in bench (rather than after). (Closed)

Created:
7 years, 8 months ago by bsalomon
Modified:
7 years, 8 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Add Xfermode bench. Also clear before rendering in bench (rather than after). Committed: http://code.google.com/p/skia/source/detail?r=8454

Patch Set 1 #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -8 lines) Patch
A bench/XfermodeBench.cpp View 1 1 chunk +70 lines, -0 lines 1 comment Download
M bench/benchmain.cpp View 2 chunks +1 line, -1 line 0 comments Download
M gyp/bench.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkXfermode.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/core/SkXfermode.cpp View 1 chunk +13 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
bsalomon
On my home iMac: whiteoak:skia1 bsalomon$ out/Release/bench --match Xfer --repeat 50 skia bench: alpha=0xFF antialias=1 ...
7 years, 8 months ago (2013-03-30 01:51:17 UTC) #1
bsalomon
7 years, 8 months ago (2013-03-30 01:51:40 UTC) #2
robertphillips
lgtm + 1 question/suggestion https://codereview.chromium.org/13334011/diff/5001/bench/XfermodeBench.cpp File bench/XfermodeBench.cpp (right): https://codereview.chromium.org/13334011/diff/5001/bench/XfermodeBench.cpp#newcode61 bench/XfermodeBench.cpp:61: What about just adding a ...
7 years, 8 months ago (2013-03-31 16:44:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/13334011/5001
7 years, 8 months ago (2013-04-01 12:51:30 UTC) #4
commit-bot: I haz the power
7 years, 8 months ago (2013-04-01 12:51:40 UTC) #5
Message was sent while issue was closed.
Change committed as 8454

Powered by Google App Engine
This is Rietveld 408576698