Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Issue 13334003: Push native libraries separately when gyp manages install (Closed)

Created:
7 years, 8 months ago by cjhopman
Modified:
7 years, 8 months ago
Reviewers:
nilesh
CC:
chromium-reviews, klundberg+watch_chromium.org, frankf+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@apkinstall
Visibility:
Public.

Description

Push native libraries separately when gyp manages install When an APK is installed, any native libraries it contains are extracted to the APK's lib folder on the device. It is actually possible to add, change, or remove libraries in that folder directly. This means, that when gyp is managing the install of APKs, the APK does not actually need to include the native library, and that can be pushed separately. This does several nice things: libraries can be pushed while a .apk is building .apk no longer needs to be rebuilt+reinstalled when a library changes if native library isn't changed, it doesn't need to be zipped+installed w/ component build, only changed libraries will need to be reinstalled BUG=158821 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=191888

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+200 lines, -9 lines) Patch
A build/android/gyp/create_device_library_links.py View 1 chunk +72 lines, -0 lines 0 comments Download
A build/android/gyp/push_libraries.py View 1 chunk +55 lines, -0 lines 0 comments Download
M build/android/process_resources.py View 1 chunk +1 line, -3 lines 0 comments Download
M build/android/pylib/build_utils.py View 2 chunks +12 lines, -0 lines 0 comments Download
M build/java_apk.gypi View 5 chunks +60 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
cjhopman
7 years, 8 months ago (2013-03-29 20:36:40 UTC) #1
nilesh
Mostly nits https://codereview.chromium.org/13334003/diff/4001/build/android/create_device_library_links.py File build/android/create_device_library_links.py (right): https://codereview.chromium.org/13334003/diff/4001/build/android/create_device_library_links.py#newcode17 build/android/create_device_library_links.py:17: def CreateLinks(options): Add a method comment. https://codereview.chromium.org/13334003/diff/4001/build/android/create_device_library_links.py#newcode20 ...
7 years, 8 months ago (2013-03-29 21:37:09 UTC) #2
cjhopman
Accidentally deleted patch set #1 ... :/ On 2013/03/29 21:37:09, nilesh wrote: > Mostly nits ...
7 years, 8 months ago (2013-04-01 22:19:44 UTC) #3
nilesh
LGTM
7 years, 8 months ago (2013-04-01 22:25:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/13334003/23005
7 years, 8 months ago (2013-04-02 16:58:24 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=113450
7 years, 8 months ago (2013-04-02 19:10:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/13334003/23005
7 years, 8 months ago (2013-04-02 19:38:03 UTC) #7
commit-bot: I haz the power
7 years, 8 months ago (2013-04-02 20:36:17 UTC) #8
Message was sent while issue was closed.
Change committed as 191888

Powered by Google App Engine
This is Rietveld 408576698