Added a StringDescription() function to safely print object pointers that may be nil.

Added a StringDescription() function to safely print object pointers that may be nil.

If expected or actual is nil, calling [[obj description] UTF8String]
returns nil and results in a call to std::string constructor with
a nil pointer. This causes a C++ exception.


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=191439

[Robert Sesek, 2013-03-29 16:33:59]

https://codereview.chromium.org/13318003/diff/2001/testing/gtest_mac.mm
File testing/gtest_mac.mm (right):

https://codereview.chromium.org/13318003/diff/2001/testing/gtest_mac.mm#newco...
testing/gtest_mac.mm:23: return [[NSString stringWithFormat:@"%@", [obj
description]] UTF8String];
Just pass |obj| as the format argument, which will call description.

[pkl (ping after 24h if needed), 2013-03-29 16:38:45]

https://codereview.chromium.org/13318003/diff/2001/testing/gtest_mac.mm
File testing/gtest_mac.mm (right):

https://codereview.chromium.org/13318003/diff/2001/testing/gtest_mac.mm#newco...
testing/gtest_mac.mm:23: return [[NSString stringWithFormat:@"%@", [obj
description]] UTF8String];
On 2013/03/29 16:33:59, rsesek wrote:
> Just pass |obj| as the format argument, which will call description.

Done.

[Robert Sesek, 2013-03-29 16:39:06]

LGTM

[commit-bot: I haz the power, 2013-03-29 16:41:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pkl@chromium.org/13318003/7002

[commit-bot: I haz the power, 2013-03-29 20:17:06]

Change committed as 191439