Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Issue 13316002: Fix downstream Android WebView build (Closed)

Created:
7 years, 8 months ago by boliu
Modified:
7 years, 8 months ago
Reviewers:
cjhopman
CC:
chromium-reviews
Visibility:
Public.

Description

Fix downstream Android WebView build Quote the expansion in java.gypi such that the shell doesn't try to expand make variables. Similar to fix in r188760 NOTRY=true BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=191359

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/java.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
cjhopman
lgtm
7 years, 8 months ago (2013-03-29 15:39:19 UTC) #1
Agrawal
LGTM
7 years, 8 months ago (2013-03-29 15:51:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/boliu@chromium.org/13316002/1
7 years, 8 months ago (2013-03-29 15:51:30 UTC) #3
commit-bot: I haz the power
7 years, 8 months ago (2013-03-29 15:51:41 UTC) #4
Message was sent while issue was closed.
Change committed as 191359

Powered by Google App Engine
This is Rietveld 408576698