Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(706)

Unified Diff: content/browser/devtools/devtools_manager_impl.h

Issue 13305002: Remove redundant DevToolsManager methods and clean up its clients. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed comments Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/devtools_manager_impl.h
diff --git a/content/browser/devtools/devtools_manager_impl.h b/content/browser/devtools/devtools_manager_impl.h
index 6e1607c33f783f39a8eb282f077f3d6b3201436c..a5f4245f3177b0948015080139ee0b0c8df0b014 100644
--- a/content/browser/devtools/devtools_manager_impl.h
+++ b/content/browser/devtools/devtools_manager_impl.h
@@ -49,15 +49,12 @@ class CONTENT_EXPORT DevToolsManagerImpl
virtual bool DispatchOnInspectorBackend(DevToolsClientHost* from,
const std::string& message) OVERRIDE;
virtual void CloseAllClientHosts() OVERRIDE;
- virtual DevToolsClientHost* GetDevToolsClientHostFor(
- DevToolsAgentHost* agent_host) OVERRIDE;
+ virtual bool IsAttached(DevToolsAgentHost* agent_host) OVERRIDE;
virtual DevToolsAgentHost* GetDevToolsAgentHostFor(
DevToolsClientHost* client_host) OVERRIDE;
virtual void RegisterDevToolsClientHostFor(
DevToolsAgentHost* agent_host,
DevToolsClientHost* client_host) OVERRIDE;
- virtual void UnregisterDevToolsClientHostFor(
- DevToolsAgentHost* agent_host) OVERRIDE;
virtual void ClientHostClosing(DevToolsClientHost* host) OVERRIDE;
private:
@@ -71,6 +68,11 @@ class CONTENT_EXPORT DevToolsManagerImpl
void UnbindClientHost(DevToolsAgentHostImpl* agent_host,
DevToolsClientHost* client_host);
+ DevToolsClientHost* GetDevToolsClientHostFor(
+ DevToolsAgentHostImpl* agent_host);
+
+ void UnregisterDevToolsClientHostFor(DevToolsAgentHostImpl* agent_host);
+
// These two maps are for tracking dependencies between inspected contents and
// their DevToolsClientHosts. They are useful for routing devtools messages
// and allow us to have at most one devtools client host per contents.

Powered by Google App Engine
This is Rietveld 408576698