Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1575)

Unified Diff: chrome/browser/extensions/api/debugger/debugger_api.cc

Issue 13305002: Remove redundant DevToolsManager methods and clean up its clients. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed comments Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/debugger/debugger_api.cc
diff --git a/chrome/browser/extensions/api/debugger/debugger_api.cc b/chrome/browser/extensions/api/debugger/debugger_api.cc
index 0af2f985022f70c46a6fe87158641aff2101903c..accb53203ae1fc740ce9893cb71da2d845f03563 100644
--- a/chrome/browser/extensions/api/debugger/debugger_api.cc
+++ b/chrome/browser/extensions/api/debugger/debugger_api.cc
@@ -525,10 +525,7 @@ bool DebuggerAttachFunction::RunImpl() {
scoped_refptr<DevToolsAgentHost> agent(DevToolsAgentHost::GetOrCreateFor(
contents_->GetRenderViewHost()));
- DevToolsClientHost* client_host = DevToolsManager::GetInstance()->
- GetDevToolsClientHostFor(agent);
-
- if (client_host != NULL) {
+ if (DevToolsManager::GetInstance()->IsAttached(agent)) {
pfeldman 2013/03/29 14:59:23 There already is IsDebuggerAttached(WebContents),
Vladislav Kaznacheev 2013/03/29 15:15:35 There is, but it is not everywhere that we have We
FormatErrorMessage(keys::kAlreadyAttachedError);
return false;
}

Powered by Google App Engine
This is Rietveld 408576698