Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5772)

Unified Diff: chrome/browser/devtools/devtools_window.h

Issue 13305002: Remove redundant DevToolsManager methods and clean up its clients. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed comments Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/devtools/devtools_window.h
diff --git a/chrome/browser/devtools/devtools_window.h b/chrome/browser/devtools/devtools_window.h
index a15ef66512e8df4bb577fff836d1e6052d3707b4..566686b131d67abd0da21ae45e06151e8d559ee4 100644
--- a/chrome/browser/devtools/devtools_window.h
+++ b/chrome/browser/devtools/devtools_window.h
@@ -82,6 +82,7 @@ class DevToolsWindow : private content::NotificationObserver,
virtual void InspectedContentsClosing() OVERRIDE;
content::RenderViewHost* GetRenderViewHost();
+ void Hide();
pfeldman 2013/03/29 14:59:23 I'd place Hide under Show.
Vladislav Kaznacheev 2013/03/29 15:15:35 Done.
void Show(DevToolsToggleAction action);
content::WebContents* web_contents() { return web_contents_; }
@@ -171,7 +172,7 @@ class DevToolsWindow : private content::NotificationObserver,
const content::FileChooserParams& params) OVERRIDE;
virtual void WebContentsFocused(content::WebContents* contents) OVERRIDE;
- static DevToolsWindow* AsDevToolsWindow(content::DevToolsClientHost*);
+ static DevToolsWindow* AsDevToolsWindow(content::DevToolsAgentHost*);
pfeldman 2013/03/29 14:59:23 "AsDevToolsWindow" name does not make sense now.
Vladislav Kaznacheev 2013/03/29 15:15:35 Done.
static DevToolsWindow* AsDevToolsWindow(content::RenderViewHost*);
// content::DevToolsFrontendHostDelegate overrides.

Powered by Google App Engine
This is Rietveld 408576698