Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4066)

Unified Diff: chrome/browser/devtools/devtools_sanity_browsertest.cc

Issue 13305002: Remove redundant DevToolsManager methods and clean up its clients. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed comments Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/devtools/devtools_sanity_browsertest.cc
diff --git a/chrome/browser/devtools/devtools_sanity_browsertest.cc b/chrome/browser/devtools/devtools_sanity_browsertest.cc
index f21f828851d82933df99b5f7825c132a32b42373..34d2a53fc026fead8d99cea097072e88042bf7c1 100644
--- a/chrome/browser/devtools/devtools_sanity_browsertest.cc
+++ b/chrome/browser/devtools/devtools_sanity_browsertest.cc
@@ -152,12 +152,11 @@ class DevToolsSanityTest : public InProcessBrowserTest {
void CloseDevToolsWindow() {
DevToolsManager* devtools_manager = DevToolsManager::GetInstance();
- // UnregisterDevToolsClientHostFor may destroy window_ so store the browser
- // first.
+ // CloseAllClientHosts may destroy window_ so store the browser first.
Browser* browser = window_->browser();
scoped_refptr<DevToolsAgentHost> agent(
pfeldman 2013/03/29 14:59:23 You no longer need this.
Vladislav Kaznacheev 2013/03/29 15:15:35 Done.
DevToolsAgentHost::GetOrCreateFor(inspected_rvh_));
- devtools_manager->UnregisterDevToolsClientHostFor(agent);
+ devtools_manager->CloseAllClientHosts();
// Wait only when DevToolsWindow has a browser. For docked DevTools, this
// is NULL and we skip the wait.

Powered by Google App Engine
This is Rietveld 408576698