content/browser/devtools/worker_devtools_manager.cc - Issue 13305002: Remove redundant DevToolsManager methods and clean up its clients.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/worker_devtools_manager.cc

Issue 13305002: Remove redundant DevToolsManager methods and clean up its clients. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressed comments Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/devtools/worker_devtools_manager.cc

diff --git a/content/browser/devtools/worker_devtools_manager.cc b/content/browser/devtools/worker_devtools_manager.cc

index 4a19c6251eff26090d116df317283e63273a5667..db5cc7484f26fd0e3eafe6dda0935a7a16abc60a 100644

--- a/content/browser/devtools/worker_devtools_manager.cc

+++ b/content/browser/devtools/worker_devtools_manager.cc

@@ -166,10 +166,7 @@ class WorkerDevToolsManager::DetachedClientHosts {

WorkerDevToolsAgentHost* agent = it->second;

DevToolsManagerImpl* devtools_manager = DevToolsManagerImpl::GetInstance();

- DevToolsClientHost* client_host =

- devtools_manager->GetDevToolsClientHostFor(agent);

- if (!client_host) {

+ if (!agent->IsAttached()) {

// Agent has no client hosts -> delete it.

RemovePendingWorkerData(id);

return;