chrome/browser/ui/webui/inspect_ui.cc - Issue 13305002: Remove redundant DevToolsManager methods and clean up its clients.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/inspect_ui.cc

Issue 13305002: Remove redundant DevToolsManager methods and clean up its clients. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressed comments Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/inspect_ui.cc

diff --git a/chrome/browser/ui/webui/inspect_ui.cc b/chrome/browser/ui/webui/inspect_ui.cc

index 437f3aaf6970c2ddf836b7e32311f6edac772c96..edcb1f68dc536904953e6a991a0cf75af03f0f44 100644

--- a/chrome/browser/ui/webui/inspect_ui.cc

+++ b/chrome/browser/ui/webui/inspect_ui.cc

@@ -115,7 +115,7 @@ bool HasClientHost(RenderViewHost* rvh) {

scoped_refptr<DevToolsAgentHost> agent(

DevToolsAgentHost::GetOrCreateFor(rvh));

- return !!DevToolsManager::GetInstance()->GetDevToolsClientHostFor(agent);

+ return agent->IsAttached();

}

DictionaryValue* BuildTargetDescriptor(RenderViewHost* rvh, bool is_tab) {