Remove redundant DevToolsManager methods and clean up its clients.

content/public/browser/devtools_manager.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_DEVTOOLS_MANAGER_H_
 #define CONTENT_PUBLIC_BROWSER_DEVTOOLS_MANAGER_H_
 
 #include <string>
 
 #include "content/common/content_export.h"
@@ skipping 16 matching lines @@
  public:
   static DevToolsManager* GetInstance();
 
   virtual ~DevToolsManager() {}
 
   // Routes devtools message from |from| client to corresponding
   // DevToolsAgentHost.
   virtual bool DispatchOnInspectorBackend(DevToolsClientHost* from,
                                           const std::string& message) = 0;
 
-  // Closes all open developer tools windows.
+  // Disconnects all client hostst.
   virtual void CloseAllClientHosts() = 0;
 
-  // Returns client attached to the |agent_host| if there is one.
-  virtual DevToolsClientHost* GetDevToolsClientHostFor(
-      DevToolsAgentHost* agent_host) = 0;
+  // Returns true if there is a client attached to the |agent_host|.
+  virtual bool IsAttached(DevToolsAgentHost* agent_host) = 0;

[pfeldman, 2013/03/29 14:59:23]

Sounds like an instance method on DevToolsAgentHost

[Vladislav Kaznacheev, 2013/03/29 15:15:35]

The real knowledge resides in DevToolsManager(Impl) and if we add this to
DevToolsAgentHost it will be a convenience method.
The whole point of this change was removing a public GetDevToolsClientHostFor.
On 2013/03/29 14:59:23, pfeldman wrote:

[pfeldman, 2013/03/30 08:54:57]

Here is how I see it: you are adding this method into the public API. It always
accepts DTAH that resides right next to DTM. All I am suggesting is to move it
there so that call sites were simpler. We should not consider DTM API separate
from DTAH. They are two pieces of one puzzle, the API the expose is a single
entity and I'm suggesting structuring it better.

[Vladislav Kaznacheev, 2013/04/01 09:26:17]

Agree. Done.

On 2013/03/30 08:54:57, pfeldman wrote:

 
   // Returns agent that has |client_host| attachd to it if there is one.
   virtual DevToolsAgentHost* GetDevToolsAgentHostFor(
       DevToolsClientHost* client_host) = 0;
 
-  // Registers new DevToolsClientHost for inspected |agent_host|. There must be
-  // no other DevToolsClientHosts registered for the |agent_host| at the moment.
+  // Registers new DevToolsClientHost for inspected |agent_host|. If there is
+  // another DevToolsClientHost registered for the |agent_host| at the moment
+  // it is disconnected.
   virtual void RegisterDevToolsClientHostFor(
       DevToolsAgentHost* agent_host,
       DevToolsClientHost* client_host) = 0;
-  // Unregisters given |agent_host|. DevToolsManager will notify corresponding
-  // client if one is attached.
-  virtual void UnregisterDevToolsClientHostFor(
-      DevToolsAgentHost* agent_host) = 0;
 
   // This method will remove all references from the manager to the
   // DevToolsClientHost and unregister all listeners related to the
   // DevToolsClientHost. Called by closing client.
   virtual void ClientHostClosing(DevToolsClientHost* client_host) = 0;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_DEVTOOLS_MANAGER_H_