Remove redundant DevToolsManager methods and clean up its clients.

chrome/browser/devtools/devtools_window.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_DEVTOOLS_DEVTOOLS_WINDOW_H_
 #define CHROME_BROWSER_DEVTOOLS_DEVTOOLS_WINDOW_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 64 matching lines @@
       DevToolsToggleAction action);
   static void InspectElement(
       content::RenderViewHost* inspected_rvh, int x, int y);
 
   virtual ~DevToolsWindow();
 
   // Overridden from DevToolsClientHost.
   virtual void InspectedContentsClosing() OVERRIDE;
   content::RenderViewHost* GetRenderViewHost();
 
+  void Hide();

[pfeldman, 2013/03/29 14:59:23]

I'd place Hide under Show.

[Vladislav Kaznacheev, 2013/03/29 15:15:35]

Done.

   void Show(DevToolsToggleAction action);
 
   content::WebContents* web_contents() { return web_contents_; }
   Browser* browser() { return browser_; }  // For tests.
   DevToolsDockSide dock_side() { return dock_side_; }
 
   content::DevToolsClientHost* GetDevToolsClientHostForTest();
 
   // Returns preferred devtools window width for given |container_width|. It
   // tries to use the saved window width, or, if none exists, 1/3 of the
@@ skipping 69 matching lines @@
   virtual void HandleKeyboardEvent(
       content::WebContents* source,
       const content::NativeWebKeyboardEvent& event) OVERRIDE;
   virtual content::JavaScriptDialogManager*
       GetJavaScriptDialogManager() OVERRIDE;
   virtual void RunFileChooser(
       content::WebContents* web_contents,
       const content::FileChooserParams& params) OVERRIDE;
   virtual void WebContentsFocused(content::WebContents* contents) OVERRIDE;
 
-  static DevToolsWindow* AsDevToolsWindow(content::DevToolsClientHost*);
+  static DevToolsWindow* AsDevToolsWindow(content::DevToolsAgentHost*);

[pfeldman, 2013/03/29 14:59:23]

"AsDevToolsWindow" name does not make sense now.

[Vladislav Kaznacheev, 2013/03/29 15:15:35]

Done.

   static DevToolsWindow* AsDevToolsWindow(content::RenderViewHost*);
 
   // content::DevToolsFrontendHostDelegate overrides.
   virtual void ActivateWindow() OVERRIDE;
   virtual void ChangeAttachedWindowHeight(unsigned height) OVERRIDE;
   virtual void CloseWindow() OVERRIDE;
   virtual void MoveWindow(int x, int y) OVERRIDE;
   virtual void SetDockSide(const std::string& side) OVERRIDE;
   virtual void OpenInNewTab(const std::string& url) OVERRIDE;
   virtual void SaveToFile(const std::string& url,
@@ skipping 33 matching lines @@
   content::NotificationRegistrar registrar_;
   scoped_ptr<content::DevToolsClientHost> frontend_host_;
   base::WeakPtrFactory<DevToolsWindow> weak_factory_;
   scoped_ptr<DevToolsFileHelper> file_helper_;
   int width_;
   int height_;
   DISALLOW_COPY_AND_ASSIGN(DevToolsWindow);
 };
 
 #endif  // CHROME_BROWSER_DEVTOOLS_DEVTOOLS_WINDOW_H_