Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Side by Side Diff: content/public/browser/devtools_manager.h

Issue 13305002: Remove redundant DevToolsManager methods and clean up its clients. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed comments Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « content/public/browser/devtools_external_agent_proxy.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_PUBLIC_BROWSER_DEVTOOLS_MANAGER_H_ 5 #ifndef CONTENT_PUBLIC_BROWSER_DEVTOOLS_MANAGER_H_
6 #define CONTENT_PUBLIC_BROWSER_DEVTOOLS_MANAGER_H_ 6 #define CONTENT_PUBLIC_BROWSER_DEVTOOLS_MANAGER_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "content/common/content_export.h" 10 #include "content/common/content_export.h"
(...skipping 16 matching lines...) Expand all
27 public: 27 public:
28 static DevToolsManager* GetInstance(); 28 static DevToolsManager* GetInstance();
29 29
30 virtual ~DevToolsManager() {} 30 virtual ~DevToolsManager() {}
31 31
32 // Routes devtools message from |from| client to corresponding 32 // Routes devtools message from |from| client to corresponding
33 // DevToolsAgentHost. 33 // DevToolsAgentHost.
34 virtual bool DispatchOnInspectorBackend(DevToolsClientHost* from, 34 virtual bool DispatchOnInspectorBackend(DevToolsClientHost* from,
35 const std::string& message) = 0; 35 const std::string& message) = 0;
36 36
37 // Closes all open developer tools windows. 37 // Disconnects all client hostst.
38 virtual void CloseAllClientHosts() = 0; 38 virtual void CloseAllClientHosts() = 0;
39 39
40 // Returns client attached to the |agent_host| if there is one. 40 // Returns agent that has |client_host| attached to it if there is one.
41 virtual DevToolsClientHost* GetDevToolsClientHostFor(
42 DevToolsAgentHost* agent_host) = 0;
43
44 // Returns agent that has |client_host| attachd to it if there is one.
45 virtual DevToolsAgentHost* GetDevToolsAgentHostFor( 41 virtual DevToolsAgentHost* GetDevToolsAgentHostFor(
46 DevToolsClientHost* client_host) = 0; 42 DevToolsClientHost* client_host) = 0;
47 43
48 // Registers new DevToolsClientHost for inspected |agent_host|. There must be 44 // Registers new DevToolsClientHost for inspected |agent_host|. If there is
49 // no other DevToolsClientHosts registered for the |agent_host| at the moment. 45 // another DevToolsClientHost registered for the |agent_host| at the moment
46 // it is disconnected.
50 virtual void RegisterDevToolsClientHostFor( 47 virtual void RegisterDevToolsClientHostFor(
51 DevToolsAgentHost* agent_host, 48 DevToolsAgentHost* agent_host,
52 DevToolsClientHost* client_host) = 0; 49 DevToolsClientHost* client_host) = 0;
53 // Unregisters given |agent_host|. DevToolsManager will notify corresponding
54 // client if one is attached.
55 virtual void UnregisterDevToolsClientHostFor(
56 DevToolsAgentHost* agent_host) = 0;
57 50
58 // This method will remove all references from the manager to the 51 // This method will remove all references from the manager to the
59 // DevToolsClientHost and unregister all listeners related to the 52 // DevToolsClientHost and unregister all listeners related to the
60 // DevToolsClientHost. Called by closing client. 53 // DevToolsClientHost. Called by closing client.
61 virtual void ClientHostClosing(DevToolsClientHost* client_host) = 0; 54 virtual void ClientHostClosing(DevToolsClientHost* client_host) = 0;
62 }; 55 };
63 56
64 } // namespace content 57 } // namespace content
65 58
66 #endif // CONTENT_PUBLIC_BROWSER_DEVTOOLS_MANAGER_H_ 59 #endif // CONTENT_PUBLIC_BROWSER_DEVTOOLS_MANAGER_H_
OLDNEW
« no previous file with comments | « content/public/browser/devtools_external_agent_proxy.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698