Android: fixes emulator support in unit test scripts.

Android: fixes emulator support in unit test scripts.

* Catch exception in CheckKVM in case kvm-ok is not available.
* Add abi option for launching emulator.

This patch is contributed by Wu Hengzhi (hengzhix.wu@intel.com).

BUG=
TEST=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193019

[bulach, 2013-04-02 09:21:05]

lgtm, thanks! please let navabi take a look as well.

one minor suggestion below.
also, the commit message would be better as something like:

"Android: fixes emulator support in unit test scripts."

(that is, prefix with "Android" so it's clearer for sheriffs this is android
only, and also it's a bit more specific on the errors it's fixing)

https://codereview.chromium.org/13300002/diff/1/build/android/pylib/utils/tes...
File build/android/pylib/utils/test_options_parser.py (right):

https://codereview.chromium.org/13300002/diff/1/build/android/pylib/utils/tes...
build/android/pylib/utils/test_options_parser.py:129:
option_parser.add_option('--abi', default='arm',
nit: maybe use 'armeabi-v7a' by default and avoid the if the file above?

[craigdh, 2013-04-02 21:15:54]

https://codereview.chromium.org/13300002/diff/1/build/android/install_emulato...
File build/android/install_emulator_deps.py (right):

https://codereview.chromium.org/13300002/diff/1/build/android/install_emulato...
build/android/install_emulator_deps.py:64: return not rc
drive-by nit: intermediate variable is unnecessary

[Shouqun Liu, 2013-04-03 00:35:27]

https://codereview.chromium.org/13300002/diff/1/build/android/install_emulato...
File build/android/install_emulator_deps.py (right):

https://codereview.chromium.org/13300002/diff/1/build/android/install_emulato...
build/android/install_emulator_deps.py:64: return not rc
On 2013/04/02 21:15:55, craigdh wrote:
> drive-by nit: intermediate variable is unnecessary

Done.

[Shouqun Liu, 2013-04-03 00:44:52]

https://codereview.chromium.org/13300002/diff/1/build/android/pylib/utils/tes...
File build/android/pylib/utils/test_options_parser.py (right):

https://codereview.chromium.org/13300002/diff/1/build/android/pylib/utils/tes...
build/android/pylib/utils/test_options_parser.py:129:
option_parser.add_option('--abi', default='arm',
On 2013/04/02 09:21:05, bulach wrote:
> nit: maybe use 'armeabi-v7a' by default and avoid the if the file above?

Done.

[Shouqun Liu, 2013-04-08 08:25:50]

kindly ping.

On 2013/04/03 00:44:52, Shouqun Liu wrote:
>
https://codereview.chromium.org/13300002/diff/1/build/android/pylib/utils/tes...
> File build/android/pylib/utils/test_options_parser.py (right):
> 
>
https://codereview.chromium.org/13300002/diff/1/build/android/pylib/utils/tes...
> build/android/pylib/utils/test_options_parser.py:129:
> option_parser.add_option('--abi', default='arm',
> On 2013/04/02 09:21:05, bulach wrote:
> > nit: maybe use 'armeabi-v7a' by default and avoid the if the file above?
> 
> Done.

[craigdh, 2013-04-08 17:37:59]

lgtm.

[navabi, 2013-04-08 19:36:45]

On 2013/04/08 17:37:59, craigdh wrote:
> lgtm.

lgtm. Some of the fixes in this patch are also in my patch;
https://codereview.chromium.org/13543008/

But, that patch does not have the gtest/dispatch.py and test_options_parser.py
changes.

Feel free to submit, I'll deal with the rebase.

[navabi, 2013-04-08 20:11:47]

https://codereview.chromium.org/13300002/diff/9001/build/android/install_emul...
File build/android/install_emulator_deps.py (right):

https://codereview.chromium.org/13300002/diff/9001/build/android/install_emul...
build/android/install_emulator_deps.py:65: return False
Nice. I have this fix in this patch:
https://codereview.chromium.org/13543008/

Will add you as reviwer for that patch.

https://codereview.chromium.org/13300002/diff/9001/build/android/pylib/utils/...
File build/android/pylib/utils/emulator.py (right):

https://codereview.chromium.org/13300002/diff/9001/build/android/pylib/utils/...
build/android/pylib/utils/emulator.py:216: '--name', self.avd_name,
Good catch. thanks.

[commit-bot: I haz the power, 2013-04-09 01:04:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/shouqun.liu@intel.com/13300002/9001

[commit-bot: I haz the power, 2013-04-09 01:13:11]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

[commit-bot: I haz the power, 2013-04-09 01:34:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/shouqun.liu@intel.com/13300002/9001

[commit-bot: I haz the power, 2013-04-09 05:40:42]

Change committed as 193019