third_party/WebKit/Source/core/paint/InlineTextBoxPainter.h - Issue 1328283005: Add support for multiple text decorations with same line positioning

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/InlineTextBoxPainter.h

Issue 1328283005: Add support for multiple text decorations with same line positioning (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp ('K') | « third_party/WebKit/Source/core/layout/LayoutObject.cpp ('k') | third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp » ('j') | third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/InlineTextBoxPainter.h

diff --git a/third_party/WebKit/Source/core/paint/InlineTextBoxPainter.h b/third_party/WebKit/Source/core/paint/InlineTextBoxPainter.h

index 05d7e443afd01e2ef710db3975890ebfe7f9c76e..3fd9a0cdf7545a773513096b19997034dc04607d 100644

--- a/third_party/WebKit/Source/core/paint/InlineTextBoxPainter.h

+++ b/third_party/WebKit/Source/core/paint/InlineTextBoxPainter.h

@@ -14,6 +14,7 @@ namespace blink {

struct CompositionUnderline;

struct PaintInfo;

+class AppliedTextDecoration;

class Color;

class ComputedStyle;

class DocumentMarker;

@@ -44,7 +45,7 @@ private:

void paintSingleCompositionBackgroundRun(GraphicsContext*, const LayoutPoint& boxOrigin, const ComputedStyle&, const Font&, Color backgroundColor, int startPos, int endPos);

template <PaintOptions>

void paintSelection(GraphicsContext*, const LayoutRect& boxRect, const ComputedStyle&, const Font&, Color textColor, LayoutTextCombine* = nullptr);

- void paintDecoration(const PaintInfo&, const LayoutPoint& boxOrigin, TextDecoration);

+ void paintDecorations(const PaintInfo&, const LayoutPoint& boxOrigin, const Vector<AppliedTextDecoration>& decorations);

void paintCompositionUnderline(GraphicsContext*, const LayoutPoint& boxOrigin, const CompositionUnderline&);

unsigned underlinePaintStart(const CompositionUnderline&);

unsigned underlinePaintEnd(const CompositionUnderline&);