chrome/renderer/resources/neterror.html - Issue 13270005: Display DNS probe results.

Unified Diff: chrome/renderer/resources/neterror.html

Issue 13270005: Display DNS probe results. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Fix FilePath initalization on Windows Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/resources/neterror.html

diff --git a/chrome/renderer/resources/neterror.html b/chrome/renderer/resources/neterror.html

index f3a30831e7726abd23eafc79180b018d03683d60..38546b73db241d36067a40f6d07fbf767f2e95d8 100644

--- a/chrome/renderer/resources/neterror.html

+++ b/chrome/renderer/resources/neterror.html

@@ -255,7 +255,6 @@ html[subframe] body {

display: none;

}

</style>

mmenke 2013/05/28 18:20:13 Don't have strong opinions about whether we should

Deprecated (see juliatuttle) 2013/06/05 21:01:47 Done.

</head>

@@ -278,6 +277,22 @@ function toggleHelpBox() {

if (window.top.location != window.location)

document.documentElement.setAttribute('subframe', '');

+function updateForDnsProbe(strings) {

+ var context = new JsEvalContext(strings);

+ // If we can update just help-box and details, do so.

+ var helpBox = document.getElementById('help-box-outer');

+ var details = document.getElementById('details');

mmenke 2013/05/28 18:20:13 Why? This seems very regression prone. If it mat

Deprecated (see juliatuttle) 2013/06/05 21:01:47 We want to avoid re-rendering the stuff that's out

+ if (helpBox && details) {

+ jstProcess(context, helpBox);

+ jstProcess(context, details);

+ } else {

+ var template = document.getElementById('t');

+ if (template) {

+ jstProcess(context, template);

+ }

</script>

mmenke 2013/05/28 18:20:13 Same comment as for style tag applies.

Deprecated (see juliatuttle) 2013/06/05 21:01:47 Done.