Display DNS probe results.

chrome/common/net/net_error_info.h

Index: chrome/common/net/net_error_info.h
diff --git a/chrome/common/net/net_error_info.h b/chrome/common/net/net_error_info.h
index 9f8d08a1baabe1b741fa69d2761ec50ff59ae667..bd367cc48013b3eec7f3c01dda14a49bfac74f7c 100644
--- a/chrome/common/net/net_error_info.h
+++ b/chrome/common/net/net_error_info.h
@@ -7,6 +7,22 @@
 
 namespace chrome_common_net {
 
+// The status of a DNS probe that the NetErrorTabHelper may or may not have
+// started.
+enum DnsProbeStatus {
+  DNS_PROBE_STARTED,  // The helper has started a probe; expect another IPC
+                      // with status _FINISHED once it returns if the tab is
+                      // still showing a DNS error page.
+
+  DNS_PROBE_FINISHED, // The helper has received a result from the DNS probe it
+                      // started.
+
+  DNS_PROBE_NOT_RUN,  // The helper is not running a DNS probe for this error
+                      // page.

[mmenke, 2013/04/01 17:44:12]

nit:  Suggest comments on the line before the status.  It's more common, and
matches the style below.

[Deprecated (see juliatuttle), 2013/04/09 20:35:49]

Done.

+
+  DNS_PROBE_STATUS_MAX
+};
+
 enum DnsProbeResult {
   DNS_PROBE_UNKNOWN,
   DNS_PROBE_NO_INTERNET,
@@ -15,6 +31,23 @@ enum DnsProbeResult {
   DNS_PROBE_MAX
 };
 
+enum DnsProbeError {

[mmenke, 2013/04/01 17:44:12]

I think separating this out from DnsProbeResult is counter-intuitive and a bit
on the ugly side.

I'd just combine them into DnsProbeStatus or somesuch.

[Deprecated (see juliatuttle), 2013/04/09 20:35:49]

Done.

+  // Error is eligible for a DNS probe; we don't know until we get an IPC
+  // whether we are running one.
+  DNS_PROBE_ERR_POSSIBLE,
+
+  // We know we are running a DNS probe, but don't know the result yet.
+  DNS_PROBE_ERR_RUNNING,
+
+  // We finished a probe.  (This must remain the last element; the result is
+  // added to it before passing to GetErrorStrings.

[mmenke, 2013/04/01 17:44:12]

nit:  Missing close parens.

[Deprecated (see juliatuttle), 2013/04/09 20:35:49]

Done.

+  DNS_PROBE_ERR_FINISHED, // + DnsProbeResult

[mmenke, 2013/04/01 17:44:12]

nit:  Two spaces between code and comment.

[Deprecated (see juliatuttle), 2013/04/09 20:35:49]

Done.

+};
+
+const char* DnsProbeErrorToString(int error);
+
+extern const char kDnsProbeErrorDomain[];
+
 }  // namespace chrome_common_net
 
 #endif  // CHROME_COMMON_NET_NET_ERROR_INFO_H_