Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: components/autofill/renderer/autofill_agent.h

Issue 13264002: Requery the autofill server when forms and input fields are dynamically added. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rename some things, move around others Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/autofill/common/forms_seen_param.h ('k') | components/autofill/renderer/autofill_agent.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/autofill/renderer/autofill_agent.h
diff --git a/components/autofill/renderer/autofill_agent.h b/components/autofill/renderer/autofill_agent.h
index 5df4b8e0a87e7336cef623d8607787678822851a..56d3fa79259152df81b84bcc06c193a64911d0c1 100644
--- a/components/autofill/renderer/autofill_agent.h
+++ b/components/autofill/renderer/autofill_agent.h
@@ -13,6 +13,7 @@
#include "base/memory/weak_ptr.h"
#include "base/time.h"
#include "base/timer.h"
+#include "components/autofill/common/forms_seen_param.h"
#include "components/autofill/renderer/form_cache.h"
#include "components/autofill/renderer/page_click_listener.h"
#include "content/public/renderer/render_view_observer.h"
@@ -103,6 +104,8 @@ class AutofillAgent : public content::RenderViewObserver,
WebKit::WebFrame* frame,
const WebKit::WebFormElement& form) OVERRIDE;
virtual void setIgnoreTextChanges(bool ignore) OVERRIDE;
+ virtual void didAssociateFormControls(
+ const WebKit::WebVector<WebKit::WebNode>& nodes) OVERRIDE;
void OnSuggestionsReturned(int query_id,
const std::vector<string16>& values,
@@ -206,6 +209,8 @@ class AutofillAgent : public content::RenderViewObserver,
// Hides any currently showing Autofill UI in the browser only.
void HideHostAutofillUi();
+ void MaybeSendDynamicFormsSeen();
+
FormCache form_cache_;
PasswordAutofillAgent* password_autofill_agent_; // WEAK reference.
@@ -256,6 +261,10 @@ class AutofillAgent : public content::RenderViewObserver,
// Whether or not |topmost_frame_| is whitelisted for Autocheckout.
bool is_whitelisted_for_autocheckout_;
+ // Whether or not new forms/fields have been dynamically added
+ // since the last time AutofillManager was sent form info.
Ilya Sherman 2013/04/09 02:17:46 nit: Something like "since the last loaded forms w
Dane Wallinga 2013/04/10 00:19:13 Done.
+ bool has_new_forms_for_manager_;
Ilya Sherman 2013/04/09 02:17:46 nit: has_new_forms_for_browser_
Dane Wallinga 2013/04/10 00:19:13 Done.
+
// Whether or not to ignore text changes. Useful for when we're committing
// a composition when we are defocusing the WebView and we don't want to
// trigger an autofill popup to show.
@@ -269,6 +278,7 @@ class AutofillAgent : public content::RenderViewObserver,
friend class PasswordAutofillAgentTest;
FRIEND_TEST_ALL_PREFIXES(ChromeRenderViewTest, FillFormElement);
FRIEND_TEST_ALL_PREFIXES(ChromeRenderViewTest, SendForms);
+ FRIEND_TEST_ALL_PREFIXES(ChromeRenderViewTest, SendDynamicForms);
FRIEND_TEST_ALL_PREFIXES(ChromeRenderViewTest, ShowAutofillWarning);
FRIEND_TEST_ALL_PREFIXES(PasswordAutofillAgentTest, WaitUsername);
FRIEND_TEST_ALL_PREFIXES(PasswordAutofillAgentTest, SuggestionAccept);
« no previous file with comments | « components/autofill/common/forms_seen_param.h ('k') | components/autofill/renderer/autofill_agent.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698