components/autofill/browser/autofill_manager.h - Issue 13264002: Requery the autofill server when forms and input fields are dynamically added.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/browser/autofill_manager.h

Issue 13264002: Requery the autofill server when forms and input fields are dynamically added. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: more fixes. you get the drill. Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/autofill/autofill_renderer_browsertest.cc ('k') | components/autofill/browser/autofill_manager.cc » ('j') | components/autofill/browser/autofill_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/browser/autofill_manager.h

diff --git a/components/autofill/browser/autofill_manager.h b/components/autofill/browser/autofill_manager.h

index fae3984f14f74c1fdfcfe5e68ed54ed7e39cad0b..b43484b8f673e6082218429c68627694331e4791 100644

--- a/components/autofill/browser/autofill_manager.h

+++ b/components/autofill/browser/autofill_manager.h

@@ -30,6 +30,7 @@

#include "components/autofill/browser/personal_data_manager.h"

#include "components/autofill/common/autocheckout_status.h"

#include "components/autofill/common/form_data.h"

+#include "components/autofill/common/forms_seen_param.h"

#include "content/public/browser/web_contents_observer.h"

#include "content/public/common/ssl_status.h"

#include "third_party/WebKit/Source/WebKit/chromium/public/WebFormElement.h"

@@ -239,7 +240,7 @@ class AutofillManager : public content::WebContentsObserver,

void OnFormsSeen(const std::vector<FormData>& forms,

const base::TimeTicks& timestamp,

- bool has_more_forms);

+ autofill::FormsSeenParam param);

Ilya Sherman 2013/04/06 00:29:39 nit: "param" is probably the most generic name you

void OnTextFieldDidChange(const FormData& form,

const FormFieldData& field,

const base::TimeTicks& timestamp);